Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-snmp: migrate to Conan v2 #19227

Merged
merged 22 commits into from
Sep 4, 2024
Merged

net-snmp: migrate to Conan v2 #19227

merged 22 commits into from
Sep 4, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Aug 16, 2023 •
edited
Loading

No description provided.

This was referenced Aug 16, 2023
Closed
Closed
@prince-chrismc prince-chrismc mentioned this pull request Aug 16, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Aug 17, 2023
Closed
@conan-center-bot

This comment has been minimized.

Sign in to view
@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@stale stale bot removed the stale label Nov 3, 2023
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur mentioned this pull request Nov 8, 2023
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur force-pushed the migrate/net-snmp branch from 3c74792 to 2b2bb27 Compare May 27, 2024 19:57
@conan-center-bot

This comment has been minimized.

Sign in to view
@valgur valgur force-pushed the migrate/net-snmp branch from 2b2bb27 to 8d30c73 Compare May 27, 2024 20:43
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 17, 2024
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 9021e52
net-snmp/5.9.4@#50a2ff2f435494d001d6d85bdd7acaa1 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libnetsnmp.so' links to system library 'm' but it is not in cpp_info.system_libs.
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libnetsnmp.dylib, libnetsnmp.40.dylib

@uilianries
Use version range for OpenSSL
2b3baa1 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Block only msvc shared
ee8ddcf 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Do not copy dll when packaging
679d9dd 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Drop neutrino support
ec64865 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Add system dependencies
4bce2fc 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Add more system libraries
260f8cd 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Copy link
Member

uilianries commented Aug 30, 2024 •
edited
Loading

I did some changes to this PR, I guess is okay at current state to be merged in case passing:

  • MSVC actually works, only fails when building shared library
  • OpenSSL 3.x is also support, added range versions: net-snmp 5.9.4 and its supported OpenSSL version net-snmp/net-snmp#768
  • Removed Neutrino support. It comes from another PR, and we have no build log that ensure it's working.
  • Add missing system libraries and frameworks
  • Removed CMake as build requirement for test package. I remember there was an old bug, but fixed in Conan client at some point.
  • Added pkg-config as tool requirement in order to find OpenSSL when cross-building on Mac.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@uilianries uilianries self-assigned this Sep 2, 2024
uilianries
uilianries approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (9fe841686e33c9a971fd1598b071edb285e93ca7):

  • net-snmp/5.9.4:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 11 (9fe841686e33c9a971fd1598b071edb285e93ca7):

  • net-snmp/5.9.4:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit b55601e into conan-io:master Sep 4, 2024
12 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
@valgur @uilianries @OMGtechy
(conan-io#19227) net-snmp: migrate to Conan v2
1765060 
* net-snmp: migrate to Conan v2

* net-snmp: bump deps

* net-snmp: merge changes from conan-io#19001

* net-snmp: add build-scope VirtualRunEnv

* net-snmp: bump version, use gnu-config

* net-snmp: add automake

* net-snmp: add libtool

* net-snmp: fix test_v1_package

* net-snmp: remove missing self.should_configure

* net-snmp: fix a patch bug

* net-snmp: add a workaround for "unresolved external symbol"

* net-snmp: MSVC build is currently broken

* Use version range for OpenSSL

Signed-off-by: Uilian Ries <[email protected]>

* Block only msvc shared

Signed-off-by: Uilian Ries <[email protected]>

* Do not copy dll when packaging

Signed-off-by: Uilian Ries <[email protected]>

* Drop neutrino support

Signed-off-by: Uilian Ries <[email protected]>

* Add system dependencies

Signed-off-by: Uilian Ries <[email protected]>

* Add more system libraries

Signed-off-by: Uilian Ries <[email protected]>

* Remove cmake as requirement on tests

Signed-off-by: Uilian Ries <[email protected]>

* Install pkgconfig to find OpenSSL when cross-building

Signed-off-by: Uilian Ries <[email protected]>

* Add zlib as mandatory requirement.

---------

Signed-off-by: Uilian Ries <[email protected]>
Co-authored-by: Uilian Ries <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@uilianries uilianries uilianries approved these changes

Assignees

@uilianries uilianries

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valgur @conan-center-bot @uilianries @AbrilRBS