-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openssl: add support for install_ssldirs
and/or install_fips
#18367
Conversation
This comment has been minimized.
This comment has been minimized.
@Hopobcn @Croydon let us know what you think of this PR and/or if you think there is a better approach to the DESTDIR vs OPENSSLDIR... For example, why is the Why could we not simply have the default openssldir be Let us know. thx! |
According to https://github.com/openssl/openssl/blob/master/INSTALL.md:
But this would violate the DEFAULT-PACKAGE-LAYOUT rule. |
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying openssl/3.x.x recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 5 (
|
Specify library name and version: openssl/v3.x.x
The various config files and certs-related files generated and installed via OpenSSL's
install_ssldirs
andinstall_fips
targets can sometimes be needed by packages usingopenssl
, either directly or repackaged when a final product embeds OpenSSL. Currently only theinstall_sw
target is installed.This PR does the following:
with_ssldirs
with_ssldirs
isFalse
(i.e. same as current behavior where onlyinstall_sw
is called)with_ssldirs
isTrue
,install_ssldirs
is called at install timeno_fips
isFalse
, theinstall_fips
target is called at install timeBecause of how the
install_ssldirs
andinstall_fips
targets heavily depend on the combo of$(DESTDIR)
and$(OPENSSLDIR)
, we have to override the previously set value ofOPENSSLDIR
in order for Make to install these files in a known/package-level subdir (i.e.etc/ssl
). This does not affect the value of OPENSSLDIR that is set in the openssl binary at build time, especially when the user set it via theopenssldir
package option.So, when the package was created using:
The resulting package's
openssl
will still embed the correctOPENSSLDIR
:Even though the ssl dir config files will be packaged at: