Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elfutils: Revise the recipe to support Conan V2 and add the latest version 0.189 #17272

Merged
merged 34 commits into from
Oct 31, 2023

Conversation

0xFireWolf
Copy link
Contributor

Specify library name and version: elfutils/0.180, 0.186, 0.189

This PR contains the following changes:

  • Revise the recipe to make it compatible with both Conan v1 and v2.
  • Upgrade all build requirements and dependencies to the latest version.
  • Implement universal patches that are necessary to compile the library in Python.
  • Remove version-specific patch files.
  • Prevent users from building the library with GCC or Clang on macOS.
    • elfutils does not support macOS.

Note that this PR is needed to fix another build error (#16799) of the package backward-cpp.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit ead6cdc
elfutils/0.186
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdw-0.186.so' links to system library 'dl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdw.so' links to system library 'dl' but it is not in cpp_info.system_libs.
elfutils/0.189
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdw-0.189.so' links to system library 'dl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdw.so' links to system library 'dl' but it is not in cpp_info.system_libs.
elfutils/0.180
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdw-0.180.so' links to system library 'dl' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libdw.so' links to system library 'dl' but it is not in cpp_info.system_libs.

@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@0xFireWolf
Copy link
Contributor Author

@RubenRBS @danimtb It has been almost six months since I submitted this PR. Any chance we can get this merged?

@stale stale bot removed the stale label Oct 16, 2023
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @0xFireWolf ,

Sorry for the long delay 😞 Our apologies.
First of all, thanks a lot for contributing!
The PR looks great! Just one comment regarding the patches applied directly by the conanfile.

recipes/elfutils/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (2e1aaf8d4b8d41a4ed7d73d52f1d1008014fbadd):

  • elfutils/0.180:
    All packages built successfully! (All logs)

  • elfutils/0.189:
    All packages built successfully! (All logs)

  • elfutils/0.186:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 9 (2e1aaf8d4b8d41a4ed7d73d52f1d1008014fbadd):

  • elfutils/0.180:
    All packages built successfully! (All logs)

  • elfutils/0.189:
    All packages built successfully! (All logs)

  • elfutils/0.186:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit b48d7fa into conan-io:master Oct 31, 2023
5 checks passed
seppeon pushed a commit to seppeon/conan-center-index that referenced this pull request Oct 21, 2024
…add the latest version 0.189

* elfutils: Add the test package for Conan 1.x.

* elfutils: Remove the entry `base_path` from each patch descriptor.

* elfutils: Make the recipe compatible with Conan 2.x.

* elfutils: `gettext` is needed otherwise `autopoint` cannot be found.

* elfutils: Fix an issue that the library `bz2` cannot be found.

* elfutils: Remove unneeded code from the recipe.

* elfutils: Upgrade the dependency `zlib` to 1.2.13.

* elfutils: Upgrade the dependency `sqlite3` to 3.41.2.

* elfutils: Upgrade the dependency `xz_utils` to 5.4.2.

* elfutils: Generate pkg-config deps for `libcurl`.

* elfutils: Upgrade the dependency `libcurl` to 8.0.1.

* elfutils: Make the test package compatible with Conan 2.x.

* elfutils: Export the path to the binary folder for Conan 2.x properly.

* elfutils: Run compiled utilities under the build environment.

* elfutils: Add the latest version 0.189.

* elfutils: Implement the patch in Python for all supported versions.

* elfutils: Use `ConanOutput.warning()` instead of deprecated `ConanOutput.warn()`.

* elfutils: Prevent users from building elfutils on macOS.

* elfutils: Remove version-specific patch files as they are now implemented in Python.

* elfutils: Add the missing entry for version 0.189 in `config.yml`.

* elfutils: Set the library search path for the test environment so that utilities dynamically linked to `libelf`, `libdw` and `libasm` can find the dylibs.

* elfutils: Add the compiler `Visual Studio` to the blacklist.

* elfutils: Add `dl` to the list of system libs of `libdw`.

* elfutils: Use `tool_requires` instead of `build_requires`.

Co-authored-by: Jordan Williams <[email protected]>

* elfutils: Use `tool_requires` instead of `build_requires`.

Co-authored-by: Jordan Williams <[email protected]>

* elfutils: Upgrade the dependency `sqlite3` to 3.42.0.

Co-authored-by: ericLemanissier <[email protected]>

* elfutils: Upgrade the dependency `libcurl` to 8.1.2.

Co-authored-by: ericLemanissier <[email protected]>

* Added patches, and package-type. Fixed bad Version import

* Removed Visual Studio as valid compiler

* Reverted all the patches

* typo

* Added is_msvc check

* renamed

---------

Co-authored-by: Jordan Williams <[email protected]>
Co-authored-by: ericLemanissier <[email protected]>
Co-authored-by: Rubén Rincón Blanco <[email protected]>
Co-authored-by: Francisco Ramirez de Anton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants