Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-c-mqtt: add missing interface definition if shared + modernize more for conan v2 #17111

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Apr 18, 2023

see https://github.com/awslabs/aws-c-mqtt/blob/v0.8.10/include/aws/mqtt/exports.h


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm mentioned this pull request Apr 19, 2023
13 tasks
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Apr 20, 2023

waiting for #17100, #17104, #17105 & #17107

@conan-center-bot

This comment has been minimized.

@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

@SpaceIm SpaceIm closed this Jun 20, 2023
@SpaceIm SpaceIm reopened this Jun 20, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Jun 30, 2023

I detected other pull requests that are modifying aws-c-mqtt/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@SpaceIm SpaceIm closed this Jul 1, 2023
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jul 1, 2023

😫

@SpaceIm SpaceIm reopened this Jul 1, 2023
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jul 1, 2023

@RubenRBS @uilianries @prince-chrismc could you review please? There are several aws PR to merge (almost 3 months that these PRs have been opened, everything in this ecosystem could have been v2 ready in one day), and they depend on each others. Waiting several weeks each time one is merged (unlocking others) is frustrating (honestly I don't want to contribute anymore), and having to ping is embarrassing.

@AbrilRBS
Copy link
Member

AbrilRBS commented Jul 4, 2023

Waiting several weeks each time one is merged (unlocking others) is frustrating (honestly I don't want to contribute anymore), and having to ping is embarrassing.

Sorry that you feel this way, just wanted to let you know that whatever your decision is, we appreciate your contributions and the time you have invested in CCI.
As for the review times, you might have noticed that in the last few weeks we have picked up the pace of reviewing, as we have internally implemented some processes to help speed things up without compromising PR quality, which we hope contributors like you are able to see and appreciate as we continue to work hard on it :)

@AbrilRBS AbrilRBS self-assigned this Jul 4, 2023
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 11 (92ebe0c8f7de2de1124f60891215603f388b811b):

  • aws-c-mqtt/0.7.12@:
    All packages built successfully! (All logs)

  • aws-c-mqtt/0.7.9@:
    All packages built successfully! (All logs)

  • aws-c-mqtt/0.7.6@:
    All packages built successfully! (All logs)

  • aws-c-mqtt/0.7.10@:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 6 (92ebe0c8f7de2de1124f60891215603f388b811b):

  • aws-c-mqtt/0.7.12@:
    All packages built successfully! (All logs)

  • aws-c-mqtt/0.7.10@:
    All packages built successfully! (All logs)

  • aws-c-mqtt/0.7.6@:
    All packages built successfully! (All logs)

  • aws-c-mqtt/0.7.9@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 263b2ad into conan-io:master Jul 6, 2023
@SpaceIm SpaceIm deleted the aws-c-mqtt-dllimport branch July 7, 2023 05:59
pezy pushed a commit to pezy/conan-center-index that referenced this pull request Jul 15, 2023
…ed + modernize more for conan v2

* add AWS_MQTT_USE_IMPORT_EXPORT interface definition if shared

* modernize more for conan v2

* more elegant way to define target for legacy generators

* aws-c-common & aws-c-io are public dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants