-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-c-mqtt: add missing interface definition if shared + modernize more for conan v2 #17111
aws-c-mqtt: add missing interface definition if shared + modernize more for conan v2 #17111
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying aws-c-mqtt/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
😫 |
This comment has been minimized.
This comment has been minimized.
@RubenRBS @uilianries @prince-chrismc could you review please? There are several aws PR to merge (almost 3 months that these PRs have been opened, everything in this ecosystem could have been v2 ready in one day), and they depend on each others. Waiting several weeks each time one is merged (unlocking others) is frustrating (honestly I don't want to contribute anymore), and having to ping is embarrassing. |
Sorry that you feel this way, just wanted to let you know that whatever your decision is, we appreciate your contributions and the time you have invested in CCI. |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 11 (
Conan v2 pipeline ✔️
All green in build 6 ( |
…ed + modernize more for conan v2 * add AWS_MQTT_USE_IMPORT_EXPORT interface definition if shared * modernize more for conan v2 * more elegant way to define target for legacy generators * aws-c-common & aws-c-io are public dependencies
see https://github.com/awslabs/aws-c-mqtt/blob/v0.8.10/include/aws/mqtt/exports.h