[qt/6.4.2] Remove .dll extension as QSystemLibrary unconditionally adds it #16317

MartinDelille · 2023-02-27T13:43:37Z

Specify library name and version: qt/6.4.2

Remove .dll extension as QSystemLibrary unconditionally adds it

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

…ds it

github-actions · 2023-02-27T13:44:59Z

🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'.

👋 @ericLemanissier @jwillikers @MartinDelille you might be interested. 😉

ghost · 2023-02-27T13:51:29Z

I detected other pull requests that are modifying qt/6.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

MartinDelille · 2023-03-07T09:43:47Z

@uilianries is it fine to push the change to fix this error or I should wait before triggering the CI for such a big package ?

MartinDelille · 2023-03-13T09:50:59Z

qt/6.4.2: Applying build-requirement: strawberryperl/5.32.1.1
[HOOK - conan-center.py] pre_source(): [IMMUTABLE SOURCES (KB-H010)] OK
qt/6.4.2: Configuring sources in C:\J\w\prod\BuildSingleReference@4/s\a78ae1\1\src
qt/6.4.2: 
ERROR: qt/6.4.2: Error in source() method, line 633
	strip_root=True, destination=destination)
	OSError: [Errno 28] No space left on device: '\\\\?\\C:\\J\\w\\prod\\BuildSingleReference@4\\s\\a78ae1\\1\\src\\qtdeclarative\\examples\\qml\\tutorials\\extending-qml\\chapter6-plugins\\app.qml'

MartinDelille · 2023-03-16T13:12:05Z

Since this changed is included in 6.4.3, I could eventually close this in favor of #16584

conan-center-bot · 2023-03-21T13:53:17Z

Conan v1 pipeline ❌

Failure in build 8 (957b6ecad275f559fc02d7238e06b22a55a84c1a):

qt/6.4.2@:
All packages built successfully! (All logs)
qt/6.3.2@:
Didn't run or was cancelled before finishing
qt/6.2.4@:
Didn't run or was cancelled before finishing

qt/6.4.1@:
CI failed to create some packages (All logs)

Logs for packageID 6e676c384b7c3bb716814ea377359de90b28c37b:

[settings]
arch=x86_64
build_type=Release
compiler=Visual Studio
compiler.runtime=MD
compiler.version=16
os=Windows
[options]
qt:shared=True

[...]
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'module-PNG-release-x86_64-data.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'module-PostgreSQL-release-x86_64-data.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'module-SQLite3-release-x86_64-data.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'module-ZLIB-release-x86_64-data.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'OpenSSL-release-x86_64-data.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'OpenSSLConfig.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'OpenSSLConfigVersion.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'PCRE2-release-x86_64-data.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'PCRE2Config.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'PCRE2ConfigVersion.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'PNG-release-x86_64-data.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'PNGConfig.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'PNGConfigVersion.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'PostgreSQL-release-x86_64-data.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'PostgreSQLConfig.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'PostgreSQLConfigVersion.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'SQLite3-release-x86_64-data.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'SQLite3Config.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'SQLite3ConfigVersion.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'ZLIB-release-x86_64-data.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'ZLIBConfig.cmake' file.
qt/6.4.1: WARN: replace_in_file didn't find pattern ' IMPORTED)
' in 'ZLIBConfigVersion.cmake' file.
qt/6.4.1: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
qt/6.4.1: ERROR: Package '6e676c384b7c3bb716814ea377359de90b28c37b' build failed
qt/6.4.1: WARN: Build folder C:\J\w\prod\BuildSingleReference@3/s\2d7346\1\build
ERROR: qt/6.4.1: Error in build() method, line 795
	cmake.build()
	ConanException: Error 1 while executing cmake --build "C:\J\w\prod\BuildSingleReference@3/s\2d7346\1\build" -- -j8

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

Failure in build 8 (957b6ecad275f559fc02d7238e06b22a55a84c1a):

qt/6.4.2@:
Error running command conan export --name qt --version 6.4.2 recipes/qt/6.x.x/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py", line 18, in <module>
    from conans import RunEnvironment, tools
ImportError: cannot import name 'RunEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

qt/6.4.1@:
Error running command conan export --name qt --version 6.4.1 recipes/qt/6.x.x/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py", line 18, in <module>
    from conans import RunEnvironment, tools
ImportError: cannot import name 'RunEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

qt/6.3.2@:
Error running command conan export --name qt --version 6.3.2 recipes/qt/6.x.x/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py", line 18, in <module>
    from conans import RunEnvironment, tools
ImportError: cannot import name 'RunEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

qt/6.2.4@:
Error running command conan export --name qt --version 6.2.4 recipes/qt/6.x.x/conanfile.py:

======== Exporting recipe to the cache ========
ERROR: Error loading conanfile at '/home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py': Unable to load conanfile in /home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod-v2_cci_PR-16317/recipes/qt/6.x.x/conanfile.py", line 18, in <module>
    from conans import RunEnvironment, tools
ImportError: cannot import name 'RunEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

github-actions · 2023-03-21T13:53:33Z

Hooks produced the following warnings for commit 957b6ec

qt/6.4.2

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\sqldrivers\qsqlodbc.dll' links to system library 'odbc32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\platforms\qdirect2d.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\platforms\qwindows.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt6Widgets.dll' links to system library 'uxtheme' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\styles\qwindowsvistastyle.dll' links to system library 'uxtheme' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt6Core.dll' links to system library 'mpr' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\platforms\qdirect2dd.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\platforms\qwindowsd.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt6Widgetsd.dll' links to system library 'uxtheme' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\styles\qwindowsvistastyled.dll' links to system library 'uxtheme' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\sqldrivers\qsqlodbcd.dll' links to system library 'odbc32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt6Cored.dll' links to system library 'mpr' but it is not in cpp_info.system_libs.

qt/6.4.1

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\platforms\qdirect2dd.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\platforms\qwindowsd.dll' links to system library 'd3d9' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt6Cored.dll' links to system library 'mpr' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\sqldrivers\qsqlodbcd.dll' links to system library 'odbc32' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\bin\Qt6Widgetsd.dll' links to system library 'uxtheme' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\styles\qwindowsvistastyled.dll' links to system library 'uxtheme' but it is not in cpp_info.system_libs.

MartinDelille · 2023-03-30T14:32:49Z

@ericLemanissier Do you think this PR should be merge or should I wait for qt/6.4.3 that include the patch ?

ericLemanissier · 2023-03-30T14:41:37Z

Better use 6.4.3 instead of adding a short-lived patch, but the discussion is not relevant, as long as C3I does not solve this disk space issue. Please still my two commits https://github.com/conan-io/conan-center-index/pull/16584/commits by the way. I won't be maintaining qt recipe any more.

MartinDelille · 2023-03-31T08:58:39Z

I can understand that maintaining this recipe is a huge amount of work!

How do you see the future of qt recipe in CCI ? The Qt company used to offer a conan package distribution but I realized today that I missed this blog post: https://www.qt.io/blog/conan-package-manager-pilot-to-end-in-december

ericLemanissier · 2023-03-31T09:26:21Z

there are already other contributors submitting fixes to qt recipe, so the future of this recipe is no different than any other recipe on CCI.
The only specific part is the version bumps (and it has always been submitted by me). For this I'll add a markdown file explaining how to do it (or maybe a python script, if I find the motivation/time).

MartinDelille · 2023-03-31T15:00:56Z

Is there a thread about it somewhere ?

ericLemanissier · 2023-03-31T16:24:10Z

No, but I feel like a documentation/python script stored next to the recipe is easier to find and use than thread on github.

MartinDelille · 2023-04-02T12:05:04Z

Yes of course. My full question was "Is there a thread about the ongoing C3I disk space issue ?

ericLemanissier · 2023-04-02T14:00:07Z

OK. I don't think there is yet

MartinDelille · 2023-04-02T18:21:28Z

I created it here: #16857

ericLemanissier · 2023-04-03T13:28:48Z

@MartinDelille instead of a python script, I just wrote a conan extension to do the recipe upgrade => conan-io/conan-extensions#20
it can be installed by doing conan config install https://github.com/ericLemanissier/conan-extensions.git then call conan qt:upgrade-qt-recipe 6.4.3 from recipes/qt folder. it only modifies the local copy. you have to manually try to build it with conan create, and do the commit afterwards. If it works as intended, please don't hesitate to use it to make a PR on CCI for qt 6.4.3 and/or 6.5.0

MartinDelille · 2023-04-05T07:24:09Z

Close in favor of #16889

[qt/6.4.2] Remove .dll extension as QSystemLibrary unconditionally ad…

8660855

…ds it

conan-center-bot added the Service Under Maintenance label Feb 27, 2023