Skip to content

antlr4-cppruntime: add version 4.12.0#16159

Merged
conan-center-bot merged 1 commit into
conan-io:masterfrom
toge:antlr4-cppruntime-4.12.0
Mar 26, 2023
Merged

antlr4-cppruntime: add version 4.12.0#16159
conan-center-bot merged 1 commit into
conan-io:masterfrom
toge:antlr4-cppruntime-4.12.0

Conversation

@toge
Copy link
Copy Markdown
Contributor

@toge toge commented Feb 20, 2023

Specify library name and version: antlr4-cppruntime/4.12.0


@conan-center-bot
Copy link
Copy Markdown
Contributor

Conan v1 pipeline ✔️

All green in build 1 (1f44badb727bee8bf437fc16f9a4a3499bffc6a8):

  • antlr4-cppruntime/4.11.1@:
    All packages built successfully! (All logs)

  • antlr4-cppruntime/4.10.1@:
    All packages built successfully! (All logs)

  • antlr4-cppruntime/4.9.3@:
    All packages built successfully! (All logs)

  • antlr4-cppruntime/4.12.0@:
    All packages built successfully! (All logs)


Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 1 (1f44badb727bee8bf437fc16f9a4a3499bffc6a8):

  • antlr4-cppruntime/4.12.0@:
    All packages built successfully! (All logs)

  • antlr4-cppruntime/4.11.1@:
    All packages built successfully! (All logs)

  • antlr4-cppruntime/4.10.1@:
    All packages built successfully! (All logs)

  • antlr4-cppruntime/4.9.3@:
    All packages built successfully! (All logs)

@ghost
Copy link
Copy Markdown

ghost commented Feb 28, 2023

I detected other pull requests that are modifying antlr4-cppruntime/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Copy link
Copy Markdown
Contributor

@michalwidera michalwidera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - look's like this change fixes V2 issues.
I think that #16328 could be dropped.
(ok look's like there is no magic - @spacelm explaied that both solutions are ok - this one occurred before c3i maintenance when v2 profiles did not force a specific compiler.cppstd)

@michalwidera
Copy link
Copy Markdown
Contributor

@toge - there are two 4.12.0 bump PR's - Yours and @0xFireWolf #16328
The second author mention one valid argument:
'Besides, #16159 does not use the new CMake options ANTLR_BUILD_SHARED and ANTLR_BUILD_STATIC that can reduce the compile time by 50%.'
Can you improve yours or merge both somehow.
I personally would like to have best code as possible here.

@conan-center-bot conan-center-bot merged commit f3752a4 into conan-io:master Mar 26, 2023
0xFireWolf pushed a commit to 0xFireWolf/conan-center-index that referenced this pull request Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants