Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cubicinterpolation: fix yml format #15628

Closed
wants to merge 1 commit into from

Conversation

ericLemanissier
Copy link
Contributor

Specify library name and version: cubicinterpolation/*

this touches only config.yml, so it does not trigger any actual build


@prince-chrismc
Copy link
Contributor

👋 We absolutely appreciate this effort but we do not want to overload the service.

I'll be working on the docs but there needs to a "minimal significance" and syntax and white space alone are not going to be making that cut. If you want these changes to be merged, I'd ask you also touch up the recipe and "modernize" it. This is going to be a new rule (i use that losely) I will block these since the bot removes the label on the next commit :)

These changes are good but just not for the QOS that we are trying to provide. I know Julius closed others and you can not open them so I'll refrain doing so to give you that chance to reach that new threshold.

@prince-chrismc prince-chrismc added the blocked Affected by an external issue and waiting until it is solved label Feb 3, 2023
@ericLemanissier
Copy link
Contributor Author

ericLemanissier commented Feb 3, 2023

OK. I thought I had made all the PRs needed to fix the linter errors on existing recipes, but actually I just realized that the github action summary from which I took the list of offenders is actually not complete (github seems to somehow filter some of the errors/warning out of the summary).
I agree that doing all the fixes would be too much CI/notifications/etc..

For the record, fixing config.yml seems to be very cheap, because C3I just inspects the PR, but does not start any actual build or test.

@ericLemanissier ericLemanissier deleted the patch-16 branch February 3, 2023 08:12
@prince-chrismc
Copy link
Contributor

Annotations the way they are being added is limited to 10 of each category.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Affected by an external issue and waiting until it is solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants