-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add watched recipes for jwillikers #15595
Add watched recipes for jwillikers #15595
Conversation
jwillikers
commented
Jan 31, 2023
- I've read the contributing guidelines.
- I've used a recent Conan client version close to the currently deployed.
- I've tried at least one configuration locally with the conan-center hook activated.
you have merge conflicts |
- uses: ./.github/actions/alert-community | ||
with: | ||
files: "recipes/boost/*/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grafikrobot Psst, you might want to look into this ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, interesting. Is this file just adding people to new PRs depending on the recipe? If so, I certainly would want to get added to a few. The boost one being one. But also b2, and a couple others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be interesting to see about automating this such that one could add to the recipe yaml files "responsible" persons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exactly how it works.
I want to start small to see how people like it before investing too much effort but I like your idea!
a7c113b
Conan v1 pipeline ❌config.yml syntax error in build 2:
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:config.yml syntax error in build 2:
|
a7c113b
to
6ebb112
Compare
Sorry, had to rebase on master to fix conflicts. |
Does that PR mean there will be some mechanism so I can subscribe and get notifications for recipes I am interested in monitoring? |
This is mechanism to get notifications :) |
There's more merge conflicts RIP |
c173ea7
6ebb112
to
c173ea7
Compare
Rebased. |
I am so sorry 😞 there's more... |
96ade15
c173ea7
to
96ade15
Compare
I definitely saw this happening in my mind 😮💨 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting those PRs merged until everyone added themselves will be pain :(
* Add watched recipes for jwillikers * Fix merge snafu