Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add watched recipes for jwillikers #15595

Merged

Conversation

jwillikers
Copy link
Contributor


prince-chrismc
prince-chrismc previously approved these changes Feb 2, 2023
@prince-chrismc
Copy link
Contributor

you have merge conflicts

Comment on lines 37 to 63
- uses: ./.github/actions/alert-community
with:
files: "recipes/boost/*/*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grafikrobot Psst, you might want to look into this ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, interesting. Is this file just adding people to new PRs depending on the recipe? If so, I certainly would want to get added to a few. The boost one being one. But also b2, and a couple others.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be interesting to see about automating this such that one could add to the recipe yaml files "responsible" persons.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly how it works.

I want to start small to see how people like it before investing too much effort but I like your idea!

grafikrobot
grafikrobot previously approved these changes Feb 3, 2023
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

config.yml syntax error in build 2:

No changes detected in this pull request

Conan v2 pipeline (informative, not required for merge) ❌

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future.

See details:

config.yml syntax error in build 2:

No changes detected in this pull request

@jwillikers jwillikers force-pushed the jwillikers-wathed-recipes branch from a7c113b to 6ebb112 Compare February 3, 2023 13:25
@jwillikers
Copy link
Contributor Author

Sorry, had to rebase on master to fix conflicts.

@a4z
Copy link
Contributor

a4z commented Feb 3, 2023

Does that PR mean there will be some mechanism so I can subscribe and get notifications for recipes I am interested in monitoring?

@prince-chrismc
Copy link
Contributor

This is mechanism to get notifications :)

prince-chrismc
prince-chrismc previously approved these changes Feb 4, 2023
@prince-chrismc prince-chrismc assigned danimtb and unassigned danimtb Feb 4, 2023
grafikrobot
grafikrobot previously approved these changes Feb 4, 2023
@prince-chrismc
Copy link
Contributor

There's more merge conflicts RIP

@jwillikers jwillikers dismissed stale reviews from grafikrobot and prince-chrismc via c173ea7 February 7, 2023 15:57
@jwillikers jwillikers force-pushed the jwillikers-wathed-recipes branch from 6ebb112 to c173ea7 Compare February 7, 2023 15:57
@jwillikers
Copy link
Contributor Author

There's more merge conflicts RIP

Rebased.

@jwillikers jwillikers requested review from prince-chrismc and removed request for danimtb February 7, 2023 15:57
grafikrobot
grafikrobot previously approved these changes Feb 7, 2023
Croydon
Croydon previously approved these changes Feb 7, 2023
SSE4
SSE4 previously approved these changes Feb 8, 2023
@prince-chrismc
Copy link
Contributor

There's more merge conflicts RIP

I am so sorry 😞 there's more...

@jwillikers jwillikers dismissed stale reviews from SSE4, Croydon, and grafikrobot via 96ade15 February 8, 2023 14:26
@jwillikers jwillikers force-pushed the jwillikers-wathed-recipes branch from c173ea7 to 96ade15 Compare February 8, 2023 14:26
@jwillikers
Copy link
Contributor Author

I definitely saw this happening in my mind 😮‍💨

Copy link
Contributor

@Croydon Croydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting those PRs merged until everyone added themselves will be pain :(

@conan-center-bot conan-center-bot merged commit 2c3936b into conan-io:master Feb 8, 2023
@jwillikers jwillikers deleted the jwillikers-wathed-recipes branch February 8, 2023 19:50
sabelka pushed a commit to sabelka/conan-center-index that referenced this pull request Feb 12, 2023
* Add watched recipes for jwillikers

* Fix merge snafu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants