-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct OS check for settings_build when calling b2 or bcp exe #15550
Conversation
I detected other pull requests that are modifying boost/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Therefore it's a good indication that this logic is useless and should be removed, since boost build on Windows didn't fail. |
fix: apply suggestions Co-authored-by: SpaceIm <[email protected]>
You can remove |
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline (informative, not required for merge) ✔️
All green in build 2 (
|
Hooks produced the following warnings for commit 60b7115boost/1.80.0
boost/1.78.0
boost/1.77.0
boost/1.81.0
boost/1.71.0
boost/1.75.0
boost/1.79.0
boost/1.74.0
boost/1.76.0
boost/1.72.0
boost/1.73.0
boost/1.70.0
|
…lling b2 or bcp exe * fix: use correct OS check for settings_build when calling b2 or bcp exe * Apply suggestions from code review fix: apply suggestions Co-authored-by: SpaceIm <[email protected]> --------- Co-authored-by: SpaceIm <[email protected]>
Specify library name and version: boost/1.81.0
The check
self._settings_build == "Windows"
will always returnFalse
, since it is the settings object.Correct check is
self._settings_build.os == "Windows"
.