Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmp3lame: modernize more #15529

Merged
merged 1 commit into from
Jan 30, 2023
Merged

libmp3lame: modernize more #15529

merged 1 commit into from
Jan 30, 2023

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 29, 2023

  • use NMakeToolchain (conan 1.55.0)
  • for clang-cl, get compilers paths from tools.build:compiler_executables then VirtualBuildEnv then fallback to default values.
  • remove autotools install workaround for MinGW (fixed in conan 1.54.0)

@SpaceIm
modernize more
0f0003c 
- use NMakeToolchain (conan 1.55.0)
- for clang-cl, get compilers paths from tools.build:compiler_executables or VirtualBuildEnv
- remove autotools install workaround for MinGW (fixed in conan 1.54.0)
@github-actions github-actions bot mentioned this pull request Jan 29, 2023
Open
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (0f0003c5eadef78a4be2e40fdcd768a609c1fee9):

  • libmp3lame/3.100@:
    All packages built successfully! (All logs)

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 1 (0f0003c5eadef78a4be2e40fdcd768a609c1fee9):

  • libmp3lame/3.100@:
    All packages built successfully! (All logs)

@prince-chrismc prince-chrismc mentioned this pull request Jan 30, 2023
Merged
1 task
@conan-center-bot conan-center-bot merged commit b399542 into conan-io:master Jan 30, 2023
@SpaceIm SpaceIm deleted the libmp3lame-modernize-more branch January 30, 2023 20:35
StellaSmith pushed a commit to StellaSmith/conan-center-index that referenced this pull request Feb 2, 2023
@SpaceIm @StellaSmith
(conan-io#15529) libmp3lame: modernize more
11cf644 
- use NMakeToolchain (conan 1.55.0)
- for clang-cl, get compilers paths from tools.build:compiler_executables or VirtualBuildEnv
- remove autotools install workaround for MinGW (fixed in conan 1.54.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwillikers jwillikers jwillikers approved these changes

@danimtb danimtb danimtb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpaceIm @conan-center-bot @danimtb @jwillikers