Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linter workflow: fix linter change test on test_package #15500

Merged
merged 11 commits into from
Feb 1, 2023
Merged

linter workflow: fix linter change test on test_package #15500

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
604d835
linter workflow: randomize the test of linter changes
ericLemanissier Jan 27, 2023
580155c
do a single pylint call for all tests
ericLemanissier Jan 27, 2023
bcf28b4
sort messages by order of occurance
ericLemanissier Jan 27, 2023
1e9ef53
Update linter-conan-v2.yml
ericLemanissier Jan 27, 2023
6208cdb
test 500 recipes
ericLemanissier Jan 27, 2023
ba76599
post result as message on PR
ericLemanissier Jan 28, 2023
d2cc8b8
fixup
ericLemanissier Jan 28, 2023
7d8a4f6
Update linter-conan-v2.yml
ericLemanissier Jan 28, 2023
7f0fe25
Update linter-conan-v2.yml
ericLemanissier Jan 28, 2023
e965663
Update linter-conan-v2.yml
ericLemanissier Jan 28, 2023
72b176a
Remove message posting
ericLemanissier Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 6 additions & 22 deletions .github/workflows/linter-conan-v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,34 +44,18 @@ jobs:
if: steps.changed_files.outputs.any_changed == 'true'
run: |
echo '## Linter summary (recipes)' >> $GITHUB_STEP_SUMMARY
i=1
for file in recipes/*/*/conanfile.py; do
if [[ $i -gt 250 ]] ; then
break
fi
echo "$i - $file"
pylint --rcfile=linter/pylintrc_recipe $file --output-format=json --output=recipes.json --score=y --exit-zero
jq 'map( select(.type=="error")) | group_by (.message)[] | {message: .[0].message, length: length}' recipes.json > recipes2.json
jq -r '" * \(.message): \(.length)"' recipes2.json >> $GITHUB_STEP_SUMMARY
(( i += 1 ))
done
pylint --rcfile=linter/pylintrc_recipe `ls recipes/*/*/conanfile.py | shuf -n 500` --output-format=json --output=recipes.json --score=y --exit-zero
jq '[map( select(.type=="error")) | group_by (.message)[] | {message: .[0].message, length: length}] | sort_by(.length) | reverse' recipes.json > recipes2.json
jq -r '.[] | " * \(.message): \(.length)"' recipes2.json >> $GITHUB_STEP_SUMMARY

- name: Execute linter over all test_package/recipes in the repository
id: linter_test_package
if: steps.changed_files.outputs.any_changed == 'true'
run: |
echo '## Linter summary (test_package)' >> $GITHUB_STEP_SUMMARY
i=1
for file in recipes/*/*/conanfile.py; do
if [[ $i -gt 250 ]] ; then
break
fi
echo "$i - $file"
pylint --rcfile=linter/pylintrc_testpackage $file --ignore-paths="recipes/[^/]*/[^/]*/test_v1[^/]*/conanfile.py --output-format=json --output=recipes.json --exit-zero
jq 'map( select(.type=="error")) | group_by (.message)[] | {message: .[0].message, length: length}' recipes.json > recipes2.json
jq -r '" * \(.message): \(.length)"' recipes2.json >> $GITHUB_STEP_SUMMARY
(( i += 1 ))
done
pylint --rcfile=linter/pylintrc_testpackage `ls recipes/*/*/test_package/conanfile.py | shuf -n 500` --output-format=json --output=recipes.json --exit-zero
jq '[map( select(.type=="error")) | group_by (.message)[] | {message: .[0].message, length: length}] | sort_by(.length) | reverse' recipes.json > recipes2.json
jq -r '.[] | " * \(.message): \(.length)"' recipes2.json >> $GITHUB_STEP_SUMMARY

conanfile_recipe:
name: Lint changed conanfile.py (v2 migration)
Expand Down