[OpenCV] Add MSMF & MSMF-DXVA as a Option #15461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yekmen
force-pushed
the
fix/opencv_world_msmf_support
branch
from
581b852 to
4ce22f0
Compare
ghost
mentioned this pull request
|
I detected other pull requests that are modifying opencv/4.x recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
ghost
mentioned this pull request
3 tasks
yekmen
force-pushed
the
fix/opencv_world_msmf_support
branch
from
4ce22f0 to
b41bc51
Compare
This comment has been minimized.
This comment has been minimized.
SpaceIm
reviewed
Jan 24, 2023
recipes/opencv/4.x/conanfile.py
Outdated
| @@ -25,6 +25,7 @@ class OpenCVConan(ConanFile): | |||
| options = { | |||
| "shared": [True, False], | |||
| "fPIC": [True, False], | |||
| "build_world":[True, False], | |||
There was a problem hiding this comment.
It's not a very good name like all recipe options build_<something>, I thinkworld is a better name and consistent with other option dnn to build opencv_dnn.
There was a problem hiding this comment.
Agree, I will changed it.
SpaceIm
reviewed
Jan 24, 2023
recipes/opencv/4.x/conanfile.py
Outdated
Comment on lines
93
to
94
| "with_msmf": False, | ||
| "with_msmf_dxva": False, |
There was a problem hiding this comment.
these options should be removed if os is not Windows, and enabled by default.
There was a problem hiding this comment.
Agree, I have not possibility to test on other operation system.
SpaceIm
reviewed
Jan 24, 2023
recipes/opencv/4.x/conanfile.py
Outdated
Comment on lines
746
to
750
| if self.options.build_world and conan_component == "opencv_world": | ||
| self.cpp_info.components[conan_component].libs = [lib_name] | ||
| elif not self.options.build_world: | ||
| self.cpp_info.components[conan_component].libs = [lib_name] | ||
|
|
There was a problem hiding this comment.
Are you sure that all other targets are defined in official OpenCV config file when world is built?
There was a problem hiding this comment.
I've checked and other targets are created, but they actually depend on opencv_world target, not the opposite. So logic proposed here is broken.
There was a problem hiding this comment.
That why I add this condition, opencv_world will combine all generated dll with only one dll which called opencv_world.dll
When world is disable, all dll will be created, tested on my side and working well.
I will recheck with the new version of the conanfile.py
There was a problem hiding this comment.
I know, but:
- all other components part of world should depend on opencv_world. They shouldn't have requires, system libs or frameworks themselves, everything should be aggregated in requires/system_libs/frameworks of opencv_world component
- 2 extra modules are never part of world: img_hash & sfm (and its static dependencies correspondence, multiview and numeric)
- ippiw is not part of world
There was a problem hiding this comment.
I've updated #15193 to add world option.
…efault Option removed if os is not windows
yekmen
force-pushed
the
fix/opencv_world_msmf_support
branch
from
b41bc51 to
87258de
Compare
yekmen
changed the title
This comment has been minimized.
This comment has been minimized.
|
I remove opencv world which is added on your pull request now. |
SpaceIm
suggested changes
Jan 30, 2023
Co-authored-by: SpaceIm <[email protected]>
Co-authored-by: SpaceIm <[email protected]>
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
@yekmen Thank you for your contribution, please, check the account |
yekmen
force-pushed
the
fix/opencv_world_msmf_support
branch
from
4a45e51 to
8f3733b
Compare
This comment has been minimized.
This comment has been minimized.
|
Closed
SSE4
approved these changes
Feb 6, 2023
|
CI is red, you can close/open to trigger it again. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
According to the CI error, don't know why my PR failed. Error : But ffmpeg is available on remote Any help is welcome |
SpaceIm
approved these changes
Feb 15, 2023
Conan v1 pipeline ✔️All green in build 18 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 22 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hooks produced the following warnings for commit a11b20copencv/4.5.1 |
prince-chrismc
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: opencv/4.5.5
Add as option to OpenCV: