wildmidi: add new recipe, version 0.4.5

[dbarkar]

Specify library name and version: wildmidi/0.4.5

WildMIDI is a simple software midi player which has a core softsynth library that can be used with other applications.

Unlike other MIDI libraries here, it supports Redbook's extended MIDI files (XMI) that are used by many old games.

There are few issues that I'd like to resolve, I don't know where else I can ask for help.

• On Windows, CMAKE_BUILD_TYPE is not set automatically from build_type, so I had to set it explicitly. Why is this happening?
• CMake's find_library can't find "libWildMidi" without ".a"/."so" extension on Linux, so I had to add it in conanfile.py. Why? Why is it working for other recipes?
• Sometimes I get this error
  [HOOK - conan-center.py] post_package_info(): ERROR: [LIBRARY DOES NOT EXIST (KB-H054)] Component wildmidi::wildmidi library 'libwildmidi' is listed in the recipe, but not found installed at self.cpp_info.libdirs. Make sure you compiled the library correctly. If so, then the library name should probably be fixed. Otherwise, then the component should be removed. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H054)
  Even though the library is in correct location, test_package and my app works well. Is it ok?
• There are files in lib/cmake describing WildMidi::libwildmidi target but this lines produce vague errors
  self.cpp_info.set_property("cmake_file_name", "wildmidi")
self.cpp_info.set_property("cmake_target_name", "libwildmidi")
  How to debug this issue?

---

• I've read the contributing guidelines.
• I've used a recent Conan client version close to the currently deployed.
• I've tried at least one configuration locally with the conan-center hook activated.

[CLAassistant]

All committers have signed the CLA.

[jwillikers]

Looks really good so far!

[jwillikers]

• On Windows, CMAKE_BUILD_TYPE is not set automatically from build_type, so I had to set it explicitly. Why is this happening?

On Windows, Conan Center's CI is building with the Visual Studio generator, which is a multi-configuration generator. Multiconfiguration generators do not set or use CMAKE_BUILD_TYPE. WildMIDI's top-level CMakeLists.txt needs to take this into account when setting things based on the build type. Generator expressions are used for the purpose of setting options based on the build type since they work for multi-configuration and single-configuration generators.
Also, WildMIDI sets the CMAKE_CONFIGURATION_TYPES variable, which is not a safe thing to do. Your workaround is probably sufficient for the Conan Center package here, though.

• CMake's find_library can't find "libWildMidi" without ".a"/."so" extension on Linux, so I had to add it in conanfile.py. Why? Why is it working for other recipes?

It probably adds the lib prefix along with the possible suffixes. Maybe try setting the library name to WildMidi instead.

• Sometimes I get this error
  [HOOK - conan-center.py] post_package_info(): ERROR: [LIBRARY DOES NOT EXIST (KB-H054)] Component wildmidi::wildmidi library 'libwildmidi' is listed in the recipe, but not found installed at self.cpp_info.libdirs. Make sure you compiled the library correctly. If so, then the library name should probably be fixed. Otherwise, then the component should be removed. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H054)
  Even though the library is in correct location, test_package and my app works well. Is it ok?

Try switching the library name to WildMidi and that might fix this.

• There are files in lib/cmake describing WildMidi::libwildmidi target but this lines produce vague errors
  self.cpp_info.set_property("cmake_file_name", "wildmidi")
self.cpp_info.set_property("cmake_target_name", "libwildmidi")
  How to debug this issue?

I suspect that these will work if you rename the library, but the cmake_target_name should be the full target name with the ::. In the new CMakeDeps generator, the file name corresponds to the name used to find the library via find_package, i.e. WildMidi in this case since the file name is WildMidiConfig.cmake.

self.cpp_info.set_property("cmake_file_name", "WildMidi")
self.cpp_info.set_property("cmake_target_name", "WildMidi::libwildmidi")

[dbarkar]

Thanks! All issues are resolved now :)
Changing library name to WildMidi worked! It still has to be libWildMidi for MSVC, though, the code is much cleaner now.
This code seemed to work:

self.cpp_info.set_property("cmake_file_name", "wildmidi")
self.cpp_info.set_property("cmake_target_name", "wildmidi::wildmidi")

I not a CMake expert, I don't really know what I'm doing, please check if it's ok :)

[jwillikers]

Just need to tweak the CMake target names and config filename to match those provided by the upstream project.

[dbarkar]

So with latest changes, I have build errors:

wildmidi/0.4.5 (test package): CMake command: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/project/test_package/build/Release/generators/conan_toolchain.cmake" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/project/test_package/."
-- Using Conan toolchain: /home/conan/project/test_package/build/Release/generators/conan_toolchain.cmake
-- Conan: Target declared 'WildMidi::libwildmidi'
-- Configuring done
-- Generating done
-- Build files have been written to: /home/conan/project/test_package/build/Release
wildmidi/0.4.5 (test package): CMake command: cmake --build "/home/conan/project/test_package/build/Release" '--' '-j28'
Scanning dependencies of target test_package
[ 50%] Building C object CMakeFiles/test_package.dir/test_package.c.o
/home/conan/project/test_package/test_package.c:4:10: fatal error: wildmidi_lib.h: No such file or directory
    4 | #include <wildmidi_lib.h>
      |          ^~~~~~~~~~~~~~~~
compilation terminated.

Test package can't find include file.
Specified in /home/conan/project/test_package/build/Release/generators/conan_toolchain.cmake:

list(PREPEND CMAKE_INCLUDE_PATH "/home/conan/.conan/data/wildmidi/0.4.5/_/_/package/dfbe50feef7f3c6223a476cd5aeadb687084a646/include")

I checked that dir and it's right there.
Also there is another error from CI.
I wonder why is it happening? I only changed the name.
Windows build works great.

[jwillikers]

Awesome work! Thanks for the contribution!

[dbarkar]

Thanks for help!

[uilianries]

Looking good, just a small comment.

[prince-chrismc]

Please do not force push 🙏 GitHub forces us to restart the review which is not fun!

[prince-chrismc]

@jcar87 the behavior of CMakeToolchain is a little wonky here if you can take a look please

[jwillikers]

I think this is more a problem with the project than CMakeToolchain. The project seems to incorrectly handle multi-configuration generators, like the Visual Studio generator.

[prince-chrismc]

Absolutely agreed but I am curious if this is the right solution of perhaps patches might be more robust... maybe fixing upstream could be an option?

[dbarkar]

So the right thing to do is to add a proper support for multi-config. I will try to make a change in upstream and come back with new PR when new version comes out.

[prince-chrismc]

I definitely think upstream could be better but I also think this is an edge case the new Conan generators weren't tested with so it would be nice to at least have test code to make sure this is intended

So I want to be clear, this PR is good :)

[prince-chrismc]

The docs says there's also a GPL licenseny reason why is that not copied?

[prince-chrismc]

Nvm I found its only the demo app

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 19 (d15bc3b5074cb54bb5f1c6cc616846eb43be61b3):

• wildmidi/0.4.5@:
  All packages built successfully! (All logs)

---

Conan v2 pipeline (informative, not required for merge) ✔️

Note: Conan v2 builds are informative and they are not required for the PR to be merged.

All green in build 20 (d15bc3b5074cb54bb5f1c6cc616846eb43be61b3):

• wildmidi/0.4.5@:
  All packages built successfully! (All logs)