-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry-cpp: option 'with_logs_preview' to enable experimental Logs #15198
opentelemetry-cpp: option 'with_logs_preview' to enable experimental Logs #15198
Conversation
I detected other pull requests that are modifying opentelemetry-cpp/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
I think this PR may be affected by #15130 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for taking the time to improve the recipe. Sorry about the delay in getting this reviewed, we're hard at work for the 2.0 launch.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline (informative, not required for merge) ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 2 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
…ble experimental Logs Co-authored-by: Ariel Machado <[email protected]>
opentelemetry-cpp/1.0.1+
fixes #15024
Looks like the feature flag has existed since the 1.0.0 release of this library: open-telemetry/opentelemetry-cpp#807
This means that adding the feature flag for all currently supported versions in
conandata.yml
shouldn't be an issue