fix: preserve dependencies between googleapis libs #14894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The googleapis package contains over 500 libraries. These libraries depend on each other, and cannot be statically linked successfully if the libraries are out of order. We use a file in the package to preserve this dependency order. It seems like too much of a maintenance burden to keep such information in the `conanfile.py` code.
This comment has been minimized.
This comment has been minimized.
ghost
mentioned this pull request
|
I detected other pull requests that are modifying googleapis/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Hooks produced the following warnings for commit 777f3f4googleapis/cci.20210730 |
Closed
This comment has been minimized.
This comment has been minimized.
uilianries
reviewed
Dec 28, 2022
This comment has been minimized.
This comment has been minimized.
Conan v1 pipelineAll green in build 8 (
Conan v2 pipeline (informative, not required for merge)Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
|
Ping, this is blocking changes to make |
uilianries
approved these changes
Jan 20, 2023
ghost
mentioned this pull request
prince-chrismc
approved these changes
Jan 25, 2023
StellaSmith
pushed a commit
to StellaSmith/conan-center-index
that referenced
this pull request
Feb 2, 2023
* fix: preserve dependencies between googleapis libs The googleapis package contains over 500 libraries. These libraries depend on each other, and cannot be statically linked successfully if the libraries are out of order. We use a file in the package to preserve this dependency order. It seems like too much of a maintenance burden to keep such information in the `conanfile.py` code. * Fix lints * Implement topological sort * Lint again * Weaken type hints * I was confused, no tsort is needed * Fix macOS build / workaround for GID_MAX macro * Fix lint errors * Fix (I think) warnings about system libraries * Address review comments * Fix build
|
The use of Components has caused issues related to how the
@coryan, I'd be very grateful if you could provide more details as to what was broken with the google-cloud-cpp recipe without the changes in this PR - as we may have to roll back the changes in the |
I am sorry to hear that.
The problem is described in #14881 thought maybe in not enough detail. Linking the target_link_libraries(my-target PRIVATE googleapis::googleapis)And you used symbols from (for example) the bigtable protos, your program would not link. In general, if Note that (currently) Before this PR, any attempt to fix that problem was unlikely to work (I think). If I am not sure these ramblings clarify anything. If they don't please let me know and I will try to help. FWIW, I have sent #15469 to upgrade |
|
Hi @coryan! Thanks so much for providing more details. This makes perfect sense. If there are tons of libraries, if they have order-dependent linkage, indeed The vendoring of .proto files (and their compiled counterparts) in certain libraries is also a known issue that the I do wonder (wild idea), given that the libraries in |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The googleapis package contains over 500 libraries. These libraries depend on each other, and cannot be statically linked successfully if the libraries are out of order.
We use a file in the package to preserve this dependency order. It seems like too much of a maintenance burden to keep such information in the
conanfile.pycode.Specify library name and version: googleapis/_
Fixes #14881