Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package] <harfbuzz>/<8.1.1>: Incorrect Include Directory Structure in harfbuzz Conan Recipe #20158

Closed
tuduongquyet opened this issue Sep 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@tuduongquyet
Copy link
Contributor

Description

Issue Title: Incorrect Include Directory Structure in harfbuzz Conan Recipe

Description:

Problem:

The harfbuzz Conan recipe currently generates an include directory structure that deviates from the standard behavior of harfbuzz when used in CMake projects. Normally, when we include harfbuzz in CMake projects, we expect to use headers like #include <harfbuzz/hb.h>. However, the current Conan recipe packages the harfbuzz headers in a way that necessitates a different include path, such as #include <hb.h>. This inconsistency in the include directory structure can lead to confusion and issues for projects using harfbuzz via Conan.

Expected Behavior:

The harfbuzz Conan package should align with the standard usage of harfbuzz, ensuring that the include directory structure remains consistent with the typical harfbuzz/hb.h format. This will ensure a smoother integration of harfbuzz into projects that rely on the standard harfbuzz header paths.

Proposed Solution:

To address this issue, it's recommended to modify the Conan recipe for harfbuzz. Specifically, in the conan.py file, we suggest adjusting the self.cpp_info.includedirs configuration to match the expected directory structure. By doing so, projects consuming harfbuzz through Conan will be able to use the standard harfbuzz/hb.h include path without any modifications.

Steps to Reproduce:

To reproduce this issue, simply create a CMake-based project that depends on the harfbuzz package from Conan, and attempt to include harfbuzz headers using #include <harfbuzz/hb.h>. You will observe that the headers are not found using the standard path, leading to compilation errors.

Package and Environment Details

  • Package Name/Version: harfbuzzz/8.1.1
  • Operating System+version: Linux Ubuntu 18.04
  • Compiler+version: GCC 8
  • Docker image: conanio/gcc8
  • Conan version: conan 1.18.0
  • Python version: Python 3.7.4

Conan profile

os=Macos
os_build=Macos
arch=x86_64
arch_build=x86_64
compiler=apple-clang
compiler.version=12.0
compiler.libcxx=libc++
build_type=Release
compiler.cppstd=11
[options]
[conf]
[build_requires]
[env]

Steps to reproduce

To reproduce this issue, simply create a CMake-based project that depends on the harfbuzz package from Conan, and attempt to include harfbuzz headers using #include <harfbuzz/hb.h>. You will observe that the headers are not found using the standard path, leading to compilation errors.

Logs

Click to expand log
No Logs
@tuduongquyet tuduongquyet added the bug Something isn't working label Sep 26, 2023
@tuduongquyet tuduongquyet changed the title [harfbuzz] <harfbuzz>/<8.1.1>: Incorrect Include Directory Structure in harfbuzz Conan Recipe [package] <harfbuzz>/<8.1.1>: Incorrect Include Directory Structure in harfbuzz Conan Recipe Sep 26, 2023
tuduongquyet pushed a commit to tuduongquyet/conan-center-index that referenced this issue Sep 26, 2023
tuduongquyet added a commit to tuduongquyet/conan-center-index that referenced this issue Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant