Bug fixes, better test coverage #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
+ Coverage 93.28% 95.45% +2.16%
==========================================
Files 12 12
Lines 1102 1099 -3
Branches 101 101
==========================================
+ Hits 1028 1049 +21
+ Misses 54 34 -20
+ Partials 20 16 -4
☔ View full report in Codecov by Sentry. |
|
Ignoring the failing codecov patch action. There's something funky going on with coverlet, looks to be a bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue are you addressing?
Partially addresses #45
How have you addressed the issue?
This PR introduces calls to DotMP that test several currently untested code paths, especially in
Parallel.FixArgs. Additionally, one of the updated tests caught a bug inGetNumThreads, so this PR introduces a bug fix for that.How have you tested your patch?
This is a testing PR :)