MAE-230: Set default manual direct debit configurations #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erawat
requested changes
Feb 3, 2021
| 'manualdirectdebit_batch_submission_queue_limit' => 50, | ||
| ]; | ||
| foreach ($configFields as $name => $value) { | ||
| civicrm_api3('setting', 'create', [$name => $value]); |
There was a problem hiding this comment.
@ahed-compucorp Would be better if we don't need foreach? We just civicrm_api3('setting', 'create', $configFields);
There was a problem hiding this comment.
I tried that but It fired an error
[is_error] => 1
[error_message] => manualdirectdebit_default_reference_prefix,manualdirectdebit_minimum_reference_prefix_length,manualdirectdebit_new_instruction_run_dates,manualdirectdebit_payment_collection_run_dates,manualdirectdebit_minimum_days_to_first_payment,manualdirectdebit_days_in_advance_for_collection_reminder,manualdirectdebit_batch_submission_queue_limit not valid settings
Now I updated to use Civi::settings()->add instead and it works.
There was a problem hiding this comment.
it does not work because "Your setting will not be active until you run flush all caches (e.g cv flush or drush cvapi System.flush)" https://docs.civicrm.org/dev/en/latest/framework/setting/#adding-a-new-setting-to-civicrm-core but using Civi::settings()->add is okay too.
ahed-compucorp
force-pushed
the
MAE-230-set-default-manual-DD-configurations
branch
from
25faaa4 to
83a6eae
Compare
erawat
approved these changes
Feb 3, 2021
ahed-compucorp
deleted the
MAE-230-set-default-manual-DD-configurations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR will create default and sensible configurations for
uk.co.compucorp.manualdirectdebitextension.Before
After