Fix: Handle RuntimeError: No response returned. Errors#582
Conversation
|
/test-on-staging |
|
/test-on-staging all |
|
|
||
| srv: | ||
| command: ["gunicorn", "pingpong:server", "-k", "uvicorn_worker.UvicornWorker", "-b", "0.0.0.0:8000", "--workers", "4", "--log-level", "debug"] | ||
| command: ["fastapi", "dev", "pingpong", "--host", "0.0.0.0", "--port", "8000", "--workers", "4"] |
There was a problem hiding this comment.
Breaking change: Note that fastapi run does not support --log-level determinations.
There was a problem hiding this comment.
my memory about this is fuzzy, but IIRC I never wanted to pass debug here in the first place, but using our env variable didn't work. (Python logging configuration is initialization order dependent and it always confused me.) You can try setting the environment LOG_LEVEL=DEBUG to keep the same log level. But it's not really an issue either way.
|
|
||
| srv: | ||
| command: ["gunicorn", "pingpong:server", "-k", "uvicorn_worker.UvicornWorker", "-b", "0.0.0.0:8000", "--workers", "4", "--log-level", "debug"] | ||
| command: ["fastapi", "dev", "pingpong", "--host", "0.0.0.0", "--port", "8000", "--workers", "4"] |
There was a problem hiding this comment.
my memory about this is fuzzy, but IIRC I never wanted to pass debug here in the first place, but using our env variable didn't work. (Python logging configuration is initialization order dependent and it always confused me.) You can try setting the environment LOG_LEVEL=DEBUG to keep the same log level. But it's not really an issue either way.
Fixes #569 by upgrading starlette through a FastAPI upgrade. For background on this error see the discussion in the
starletterepo here.Resolves #550 by upgrading the Docker commands to use
fastapi run. Note however thatfastapi runis simply a wrapper callinguvicorn, with less options. See here.