Support matchAll* variants in PHPStan extensions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seldaek
reviewed
Aug 19, 2024
| @@ -52,6 +55,10 @@ public function getParameterOutTypeFromStaticMethodCall(MethodReflection $method | |||
| return null; | |||
| } | |||
|
|
|||
| if (stripos($methodReflection->getName(), 'matchAll') !== false) { | |||
| return $this->regexShapeMatcher->matchAllExpr($patternArg->value, $flagsType, TrinaryLogic::createMaybe(), $scope); | |||
There was a problem hiding this comment.
This probably should be conditional on the matchAllExpr method existing, otherwise older phpstan version will break.. So either that or we need to bump the phpstan/phpstan conflict rule?
There was a problem hiding this comment.
Agree.
I am on vacation atm - cannot work on it now
Seldaek
reviewed
Aug 19, 2024
| @@ -67,7 +71,12 @@ public function specifyTypes(MethodReflection $methodReflection, StaticCall $nod | |||
| return new SpecifiedTypes(); | |||
| } | |||
|
|
|||
| $matchedType = $this->regexShapeMatcher->matchExpr($patternArg->value, $flagsType, TrinaryLogic::createFromBoolean($context->true()), $scope); | |||
| if (stripos($methodReflection->getName(), 'matchAll') !== false) { | |||
| $matchedType = $this->regexShapeMatcher->matchAllExpr($patternArg->value, $flagsType, TrinaryLogic::createFromBoolean($context->true()), $scope); | |||
There was a problem hiding this comment.
Same here.. Probably easiest to bump the conflict rule tbh, not worth having ugly code here.
There was a problem hiding this comment.
Ok I did this myself in a follow-up commit. Thanks for the PR! I guess preg_replace_callback could also be done now with phpstan 1.11.10?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analog phpstan/phpstan-src#3256