Enable PHPStan Extensions outside of bleeding edge

[staabm]

ondrej enabled the preg-match $matches inference feature with 1.12.x by default as it seems stable enough for general use.

the feature flag %featureToggles.narrowPregMatches% we rely on will be dropped with 1.12.

so there are 2 possible ways to handle it:

1. we re-introduce the feature-flag as a noop in PHPstan 1.12.x as suggested by ondrej
2. we remove usage of the feature flag, as we think the feature is already stable enough (so PHPStan-src 1.12.x does not need to take care of us using a non BC promise feature-flag)

@Seldaek wdyt about this options. do you feel confident to remove the feature flag for bleeding edge already within composer/pcre?

[staabm]

btw: I think this UnsafeStrictGroupsCallRule conditional tag didn't work as expected because we always registered the class as a rule at line 21.
to make this conditional-tag work, we should have registered the rule as a service without a tag (and not below the rules: section) -> I think the rule was enabled no matter bleeding edge

[Seldaek]

Yeah I'd say let's remove it..

[staabm]

I agree.

people can stick with 2.2.0 or 3.2.0 in case a PHPStan-src fix is needed for some edge-case array-shape matching.
and I feel confident about the work we achieved already 🚀

[staabm]

regarding the failed build: I found sebastianbergmann/phpunit#5062 but could not yet find a way to repair the build (unrelated to the actual PR)

[staabm]

Put it back to draft, because I want to look into preg_match_all() before we drop bleeding edge

[Seldaek]

Thanks