Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(variables): Add number suffix support to the variable extractor #711

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

idsulik
Copy link
Contributor

@idsulik idsulik commented Nov 12, 2024

Fixes docker/compose#12285

Added support for suffix support in variable names, for example:

${FOO_1}
${BAR_1:-with-default}

@idsulik idsulik requested a review from ndeloof as a code owner November 12, 2024 10:02
@ndeloof ndeloof merged commit 58f8cad into compose-spec:main Nov 12, 2024
8 checks passed
@MikaelElkiaer
Copy link

@idsulik Looks great.

Just to be clear, this will also work for ${FOO1}, right?

@idsulik
Copy link
Contributor Author

idsulik commented Nov 12, 2024

@MikaelElkiaer thank you! yes it will work for ${FOO1} as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot properly list variables with numbers in the key
3 participants