-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow empty (null) lists #670
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Lionello Lunesu <[email protected]>
897e883
to
2a786b7
Compare
If this is the right approach I can add |
@@ -103,12 +108,12 @@ | |||
"context": {"type": "string"}, | |||
"dockerfile": {"type": "string"}, | |||
"dockerfile_inline": {"type": "string"}, | |||
"entitlements": {"type": "array", "items": {"type": "string"}}, | |||
"entitlements": {"$ref": "#/definitions/list_of_strings"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of these could possibly be list_of_unique_strings
but that would technically be a breaking change.
they should get a warning from the IDE (if an extension is installed) or they get an error when running |
That's right, you do get an error when you do |
I agree there's no reason we consider an |
This happens when some users are not very familiar with the Compose file syntax: during testing they'd comment out the environment variables, but not the actual
environment:
key, and the Compose file would fail to load:This change adds
"null"
as a valid type for many of the lists in the JSON schema:include
service.blkio_config.device_read_bps
service.blkio_config.device_read_iops
service.blkio_config.device_write_bps
service.blkio_config.device_write_iops
service.blkio_config.weight_device
service.expose
service.group_add
service.ports
service.volumes
development.watch
deployment.placement.preferences
generic_resources
devices
network.ipam.config
command
env_file
list_of_unique_strings
(was:list_of_strings
)list_of_strings
list_or_dict
service_config_or_secret