networks.enable_ipv6: make it optional #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field isn't marked as required in the compose-spec, but it's implemented as a basic `bool` in this package. This means it automatically defaults to `false` when not specified. A recent change was made to Docker Engine to allow users to define a daemon-wide default value for the equivalent API field. Without this change, Compose would always send a value to the Engine API, preventing it from defining its own default value. See moby/moby#47867. Signed-off-by: Albin Kerouanton <[email protected]>
|
I revendored this PR in docker/compose (see docker/compose#11893) and tested with the following Compose file with a daemon built from moby/moby@master. The daemon was started with and without services:
netshoot:
image: nicolaka/netshoot
command: /bin/sleep infinity
networks:
default: {}
v6enabled: {}
v6disabled: {}
networks:
default: {}
v6enabled:
enable_ipv6: true
v6disabled:
enable_ipv6: false |
|
LGTM as this reflects change in the API https://github.com/moby/moby/pull/47867/files#diff-28bc7f6688f2249afb33f1c3b4558c3bf1bfcda87f1b8e385bc8a5f04b8bdfeaL454-R454 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field isn't marked as required in the compose-spec, but it's implemented as a basic
boolin this package. This means it automatically defaults tofalsewhen not specified.A recent change was made to Docker Engine to allow users to define a daemon-wide default value for the equivalent API field. Without this change, Compose would always send a value to the Engine API, preventing it from defining its own default value.
See moby/moby#47867.