Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ulimit parsing #535

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix ulimit parsing #535

merged 1 commit into from
Jan 19, 2024

Conversation

ndeloof
Copy link
Collaborator

@ndeloof ndeloof commented Jan 19, 2024

canonical transformation must keep ulimit as an int or struct to match json schema (validated after a merge)
converting int to internal single field must take place during the decode phase, as this is specific to go-structs design

fixes docker/compose#11353 (comment)

Signed-off-by: Nicolas De Loof <[email protected]>
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours enabled auto-merge (rebase) January 19, 2024 16:17
@glours glours merged commit 3c8d69f into compose-spec:main Jan 19, 2024
8 checks passed
@ndeloof ndeloof deleted the decode_ulimit branch January 19, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Version 2.24.0 breaks overriding integer environment variable
2 participants