Bump golang minimal version to 1.21 and 1.22 #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrotko
force-pushed
the
upgrade-exp-version
branch
from
26f893c to
6ff1656
Compare
ndeloof
reviewed
Feb 7, 2024
| @@ -179,7 +180,7 @@ func convertIntoSequence(value any) []any { | |||
| i++ | |||
| } | |||
| slices.SortFunc(seq, func(a, b any) int { | |||
| return compare(a.(string), b.(string)) | |||
There was a problem hiding this comment.
please also remove this func, as we won't need the conditional build anymore
jhrotko
commented
Feb 7, 2024
| @@ -179,7 +180,7 @@ func convertIntoSequence(value any) []any { | |||
| i++ | |||
| } | |||
| slices.SortFunc(seq, func(a, b any) int { | |||
| return compare(a.(string), b.(string)) | |||
There was a problem hiding this comment.
So, I am not sure, should we use compare or cmp.Compare? @ndeloof
There was a problem hiding this comment.
cmp.Compare should be safe (?), at least we already use it on go1.21+, so better just remove the compare/compare120 hack
ndeloof
approved these changes
Feb 7, 2024
jhrotko
changed the title
jhrotko
force-pushed
the
upgrade-exp-version
branch
2 times, most recently
from
eb4780b to
8d96c65
Compare
Signed-off-by: jhrotko <[email protected]>
jhrotko
force-pushed
the
upgrade-exp-version
branch
from
8d96c65 to
22508c3
Compare
glours
approved these changes
Feb 7, 2024
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to update the version of https://pkg.go.dev/golang.org/x/[email protected]/slices we need to update the
slices.SortFuncto be compatible withy the latest version.Related with #519