Read config file content if missing #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndeloof Looks like I mistakenly closed the other PR. Didn't know that an empty push would automatically close it... Anyhow, this commit should be signed off. |
aksiksi
force-pushed
the
main
branch
2 times, most recently
from
bd5321f to
e30db43
Compare
This ensures that project name validation occurs in cases where the content is missing (e.g., when constructed via ToConfigFiles). Signed-off-by: Assil Ksiksi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that project name validation occurs in cases where the content is missing (e.g., when constructed via
ToConfigFiles).I opted to do the read during project name parsing for two reasons:
Contentis not set (not justToConfigFiles).ToConfigFilesfunction.I also had to fix a few tests that were not setting the project correctly.
Fixes #489.