-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shorthands to builder #151
base: master
Are you sure you want to change the base?
Conversation
also added an builder.all(__dirname + '/build', function (err, build) {
write('build.js', build.scripts);
write('build.css', build.styles);
}); |
i'm +1 but the |
we could put it inside |
* Mixin shorthands. | ||
*/ | ||
|
||
for (var key in shorthands) Builder.prototype[key] = shorthands[key]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
proto ftw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or do we use that already above somewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah we dont i dont think. seems weird though to set the shorthands as the proto?
this way people don't have to always build up with internal plugins to build the native types that are defined in the spec. makes it trivial to do..