Various fixes for coercions #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mikesperber
commented
Feb 22, 2024
mikesperber
commented
- In FunCo co1 co2, co1 is oriented the other way around from co2.
- Various places confused the arrow of the coercion with the arrow of the function value being coerced.
|
Uff, that’s been paged out for quite a while. The changes look at least plausible, and if they make the linter more happy, they are probably reasonable. |
- In FunCo co1 co2, co1 is oriented the other way around from co2. - Various places confused the arrow of the coercion with the arrow of the function value being coerced.
mikesperber
force-pushed
the
coercion-fixes
branch
from
6589c21 to
7d1b52c
Compare
|
@nomeata Thanks for looking at this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.