Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix permissions on Haddock before deploying #117

Merged

Conversation

sellout
Copy link
Contributor

@sellout sellout commented Jan 28, 2024

It’s difficult to test branch-specific GitHub workflows like this, so the final
deployment bits couldn’t be tested before merging the previous PR.

In this case, I merged the change into master on my fork to ensure it actually completed. So you can see the result at https://con-kitty.github.io/concat/.

It’s difficult to test branch-specific GitHub workflows like this, so the final
deployment bits couldn’t be tested before merging the previous PR.
@sellout
Copy link
Contributor Author

sellout commented Jan 28, 2024

Is there a good way to test workflows like this? They won’t run on arbitrary branches, and testing on master (even on a fork) seems wrong.

@kenranunderscore
Copy link
Collaborator

Sorry, I don't have any idea either how to best test these kinds of changes :/
But very cool that we can see the docs online, thanks!

@mikesperber mikesperber self-requested a review January 29, 2024 13:25
Copy link
Contributor

@mikesperber mikesperber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@sellout sellout merged commit 15b2a55 into compiling-to-categories:master Jan 29, 2024
50 of 70 checks passed
@sellout sellout deleted the fix-haddock-deploy branch January 29, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants