Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ignore .egg-info #27

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix: ignore .egg-info #27

merged 1 commit into from
Dec 5, 2024

Conversation

thekaveman
Copy link
Member

Otherwise any existing directory is copied with the Docker build, which then fails on pip install -e .[dev].

@thekaveman
fix(devcontainer): ignore .egg-info
5f91f9c 
Otherwise any existing directory is copied with the Docker build, which then fails on `pip install -e .[dev]`.
@thekaveman thekaveman requested a review from a team as a code owner December 5, 2024 20:23
@thekaveman thekaveman self-assigned this Dec 5, 2024
@thekaveman thekaveman added the bug Something isn't working label Dec 5, 2024
@thekaveman thekaveman added this to the Initial project setup milestone Dec 5, 2024
lalver1
lalver1 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@lalver1 lalver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
The devcontainer still works and pip install -e .[dev] does not fail

@thekaveman thekaveman merged commit 12f4a54 into main Dec 5, 2024
1 check passed
@thekaveman thekaveman deleted the fix/devcontainer branch December 5, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalver1 lalver1 lalver1 approved these changes

Assignees

@thekaveman thekaveman

Labels
bug Something isn't working
Projects
PeMS
Status: Done
Milestone
Initial project setup
Development

Successfully merging this pull request may close these issues.
2 participants
@thekaveman @lalver1