Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: set up devcontainer #22

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Feat: set up devcontainer #22

merged 1 commit into from
Dec 3, 2024

Conversation

lalver1
Copy link
Member

@lalver1 lalver1 commented Dec 3, 2024

Closes #3 (and supersedes PR 21 that got stuck on recent push is still being processed)

This PR sets up a devcontainer similar to https://github.com/compilerla/template-devcontainer

  • based on Python 3.12
  • configured with a non-root user
  • withpre-commit configured
  • with .vscode/settings.json configured for basic formatting

note that .dockerignore is required for the step "install pre-commit environments in throwaway Git repository" in the Dockerfile
@lalver1 lalver1 self-assigned this Dec 3, 2024
@lalver1 lalver1 marked this pull request as ready for review December 3, 2024 22:45
@lalver1 lalver1 requested a review from a team as a code owner December 3, 2024 22:45
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice start! 👍 👍

@thekaveman thekaveman added this to the Initial project setup milestone Dec 3, 2024
@lalver1 lalver1 merged commit 0212fd2 into main Dec 3, 2024
@lalver1 lalver1 deleted the feat/devcontainer-setup branch December 3, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial devcontainer setup
2 participants