add GetValueKind
#758
Merged
add GetValueKind
#758
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
Nov 26, 2025
include/CppInterOp/CppInterOp.h
Outdated
| static_cast<unsigned char>(b)); | ||
| } | ||
|
|
||
| enum ReferenceValueKind : std::uint8_t { |
Contributor
There was a problem hiding this comment.
Suggested change
| enum ReferenceValueKind : std::uint8_t { | |
| enum ValueKind : std::uint8_t { |
include/CppInterOp/CppInterOp.h
Outdated
| /// Checks if type is a LValue reference | ||
| CPPINTEROP_API bool IsRValueReferenceType(TCppType_t type); | ||
| /// Get if lvalue or rvalue reference | ||
| CPPINTEROP_API ReferenceValueKind GetReferenceValueKind(TCppType_t type); |
Contributor
There was a problem hiding this comment.
Suggested change
| CPPINTEROP_API ReferenceValueKind GetReferenceValueKind(TCppType_t type); | |
| CPPINTEROP_API ValueKind GetValueKind(TCppType_t type); |
This should take an arbitrary type and value kinds..
Vipul-Cariappa
force-pushed
the
dev/GetReferenceValueKind
branch
from
45c81c1 to
a882d9d
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
=======================================
Coverage 79.04% 79.04%
=======================================
Files 9 9
Lines 3879 3880 +1
=======================================
+ Hits 3066 3067 +1
Misses 813 813
🚀 New features to boost your workflow:
|
and remove `IsLValueReferenceType` & `IsRValueReferenceType`
Vipul-Cariappa
force-pushed
the
dev/GetReferenceValueKind
branch
from
a882d9d to
43f1fe1
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Vipul-Cariappa
merged commit 6623df3
into
compiler-research:main
26 of 36 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
And remove
IsLValueReferenceType&IsRValueReferenceTypeFixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist