GetBinaryOperator returns vector of functions #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
- Coverage 73.47% 73.44% -0.04%
==========================================
Files 8 8
Lines 3005 2990 -15
==========================================
- Hits 2208 2196 -12
+ Misses 797 794 -3
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Sep 7, 2024
| ops.clear(); | ||
|
|
||
| Cpp::GetBinaryOperator(Cpp::GetGlobalScope(), Cpp::BinaryOperator::Mul, ops); | ||
| EXPECT_EQ(ops.size(), 0); |
Contributor
There was a problem hiding this comment.
Do we have an example involving argument dependent lookup?
Collaborator
Author
There was a problem hiding this comment.
No. I have not implemented the argument dependent lookup with this PR.
I have made changes to take std::vector& as an argument and populate it with the operators. Removing the previous string comparisons to resolve the overloaded operator.
We discussed this after the monthly meeting the day before yesterday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.