Added Dpcumentation of cppyy Enhancements and how they relate to LibInterOp #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
QuillPusher
commented
Oct 30, 2023
QuillPusher
commented
- Reducing cppyy Dependencies
- Code Example
- cppyy components
- cppyy repos (enhanced forks+upstream)
- Credits to Devs
- Further Reading Links
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
+ Coverage 72.65% 77.55% +4.89%
==========================================
Files 8 8
Lines 2889 2887 -2
==========================================
+ Hits 2099 2239 +140
+ Misses 790 648 -142 |
vgvassilev
reviewed
Oct 31, 2023
QuillPusher
force-pushed
the
Add_cppyy_UseCase_to_InterOpDoc
branch
from
412d65b to
927d649
Compare
Contributor
Author
|
Minor review change committed and force-pushed to one commit |
davidlange6
reviewed
Nov 6, 2023
QuillPusher
force-pushed
the
Add_cppyy_UseCase_to_InterOpDoc
branch
from
2e19b16 to
49fb9e4
Compare
Contributor
Author
|
Hello @sudo-panda and @vgvassilev , @davidlange6 has asked some tough questions in this review. I don't have clear answers for all. Please see the above unresolved comments and share your insights for more clarity |
vgvassilev
reviewed
Nov 13, 2023
QuillPusher
force-pushed
the
Add_cppyy_UseCase_to_InterOpDoc
branch
from
9b98af4 to
e90662f
Compare
davidlange6
reviewed
Nov 14, 2023
davidlange6
reviewed
Nov 14, 2023
vgvassilev
reviewed
Nov 15, 2023
davidlange6
reviewed
Dec 5, 2023
davidlange6
reviewed
Dec 5, 2023
davidlange6
reviewed
Dec 5, 2023
Contributor
Author
|
Thanks @davidlange6 , requested changes made |
QuillPusher
force-pushed
the
Add_cppyy_UseCase_to_InterOpDoc
branch
from
7878d08 to
b9cfb10
Compare
David's review 2 changes - changed section heading and writerup from "**How cppyy relates to CppInterOp**" to "**How cppyy leverages CppInterOp**" - changed all occurrences of cppyy in small case letters Squashing the incorporated Review changes - Reviewers: Parth, David and Vassil How cppyy relates to CppInterOp and how it works - Reducing cppyy Dependencies - Code Example - cppyy components - cppyy repos (enhanced forks+upstream) - Credits to Devs - Further Reading Links New commit: - Added some changes after David's Review (see comment responses) New Commit 2: Text changes suggested by Vassil after David's review
vgvassilev
reviewed
Dec 20, 2023
Contributor
Author
|
Thanks @vgvassilev , the requested changes have been made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.