Add test to check base virtual method call #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's a quite often used idiom in C which hides the implementation details of the underlying tag declaration.
This patch removes the external calls to getInterpreter/getSema in favor of storing them as static variables. That improves the ABI resilience of the API.
…ation - Added Comments (Function Definitions) for CppInterOp Doxygen documentation - Incorporated minor changes in Interop.cpp and InterOp.h, as suggested in Vassil's review - changes to preamble section reverted - the "this pointer" term reverted - Made sentence openings consistent (e.g., Identifies > Checks) - Executed `git-clang-format` in InterOp.cpp and InterOp.h
Signed-off-by: <[email protected]> Krishna Narayanan
- Added CppInterOp Intro writeup - Removed (previously LibInterOp) - Broke the lines at 80 columns (except code snippets) - Worked with Krishna to add improved Build Instructions Co-Authored-By: Krishna Narayanan <[email protected]>
This patch should fix the valgrind issues.
|
As discussed in the last meeting we had to do some renaming. GitHub decided to close this PR probably because we rewrote our history. Can you reopen the PR against the new version of main? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a derived class object with a base class virtual method the derived class virtual method is being called.
cc: @vgvassilev