Fix upload workflow: retired ubuntu-20.04 runner, checkout v2 -> v4 - #1
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR revives and hardens the repository’s GitHub Actions setup by fixing a broken upload workflow runner target and adding automated workflow linting as part of the org-wide actionlint rollout.
Changes:
- Update the upload workflow to use a supported GitHub-hosted runner label (
ubuntu-latest) and modernactions/checkout@v4. - Add a dedicated
lint-actionsworkflow that runsactionlinton pushes/PRs that modify workflow files. - Introduce
.github/actionlint.yamlto define self-hosted runner labels and tune shellcheck-related ignores.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/upload.yml | Switches to a supported runner label and updates actions/checkout to keep the manual upload workflow runnable. |
| .github/workflows/lint-actions.yml | Adds CI linting for workflow changes using actionlint to catch schema/expression/runner-label issues early. |
| .github/actionlint.yaml | Configures actionlint runner-label awareness and shellcheck ignore patterns for workflow scripts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| jobs: | ||
| build_and_upload: | ||
| runs-on: ubuntu-20.04 | ||
| runs-on: ubuntu-latest |
Member
Author
There was a problem hiding this comment.
Declining, with some irony: a pinned runner version is exactly what broke this workflow in the first place — it was pinned to ubuntu-20.04, the label was retired, and every dispatch queued forever. For a tiny manual S3-upload job, tracking ubuntu-latest is the maintenance-free choice; pinning just schedules the next silent death.
| jobs: | ||
| actionlint: | ||
| if: github.repository_owner == 'compiler-explorer' | ||
| runs-on: ubuntu-latest |
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
| - name: Check workflow files | ||
| uses: docker://rhysd/actionlint:1.7.12 |
- upload.yml targeted ubuntu-20.04, a retired GitHub-hosted label: dispatches would queue forever with no runner. Now ubuntu-latest. - actions/checkout v2 -> v4 Found by an org-wide actionlint sweep; the lint tooling itself is staying in the core repos only, but these fixes stand on their own. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mattgodbolt
changed the title
mattgodbolt
force-pushed
the
add-actionlint
branch
from
July 10, 2026 21:52
d06e44d to
32f9d36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by an org-wide actionlint sweep. Per review feedback the lint tooling itself is staying in the core repos (compiler-explorer, infra, compiler-workflows) — this PR keeps just the fixes, which stand on their own:
🤖 Generated with Claude Code