Skip to content

Add actionlint to pre-commit #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattgodbolt merged 1 commit into from
Jul 12, 2026
Merged

Add actionlint to pre-commit #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/actionlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
self-hosted-runner:
# Labels of our self-hosted CE runners (see the ce-ci repository)
labels:
- ce
- small
- medium
1 change: 1 addition & 0 deletions .github/workflows/install-compilers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,5 @@ jobs:
if [[ "$FORCE" == "true" ]]; then
FORCE_FLAG="--force"
fi
# shellcheck disable=SC2086 # word-splitting the flag and filter word lists is the point
sudo bin/ce_install --check-user nobody $ENABLE_FLAG install $FORCE_FLAG $COMPILERS
4 changes: 4 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ repos:
rev: 2.1.5
hooks:
- id: shellcheck
- repo: https://github.com/rhysd/actionlint
rev: v1.7.12
hooks:
- id: actionlint
Comment on lines +13 to +16

@mattgodbolt mattgodbolt Jul 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declining — this is out of date: pre-commit auto-provisions a Go toolchain for language: golang hooks since pre-commit 3.0. Empirically verified while building this PR: the machine it was developed on has no go on PATH at all, and pre-commit run actionlint installed and built the hook fine (the downloaded toolchain lives in the hook's cached env). CI uses the same mechanism via make pre-commit, so nothing depends on runner images shipping Go.

- repo: local
hooks:
- id: builds-up-to-date
Expand Down