Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding rustc-cg-gcc #2746

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Conversation

dkm
Copy link
Member

@dkm dkm commented Jun 28, 2021

GCC backend for rustc is still in a very early state.
It is in the process of being merged in main rustc source:
rust-lang/compiler-team#442

Currently reusing main rust compiler class and simply remove -Cllvm= argument if any (only for intel asm syntax).

Disabling binary until the result is more friendly (currently binary are too big).

refs #2683

@dkm dkm requested a review from mattgodbolt as a code owner June 28, 2021 20:26
@dkm dkm marked this pull request as draft June 28, 2021 20:26
@dkm dkm force-pushed the pr/rustc_cg_gcc branch 2 times, most recently from c99121b to bfcdd40 Compare June 30, 2021 20:16
@dkm
Copy link
Member Author

dkm commented Jul 6, 2021

Disabled binary support until it produces lighter files.
The -Cllvm filtering may be problematic as it seems it will also be the vector for providing arguments to gcc. I may have to modify this later when working on getting dump files

@dkm
Copy link
Member Author

dkm commented Jul 7, 2021

@dkm dkm marked this pull request as ready for review July 7, 2021 20:17
GCC backend for rustc is still in a very early state.
It is in the process of being merged in main rustc source:
rust-lang/compiler-team#442

Currently reusing main rust compiler class and simply remove -Cllvm= argument if
any (only for intel asm syntax).

Disabling binary until the result is more friendly (currently binary are too
big).

refs compiler-explorer#2683
@mattgodbolt
Copy link
Member

Will let the admin daily builds run to ensure things are working. Hope to merge tomorrow!

@mattgodbolt
Copy link
Member

Built and installed ok!

Copy link
Member

@mattgodbolt mattgodbolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurrah! Will test out in staging shortly.

}

optionsForFilter(filters, outputFilename, userOptions) {
// these options are direcly taken from rustc_codegen_gcc doc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge as-is to get us going, but most of these can be const (I know it's hardly C++ const, but I like to try my best :) )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning on doing some changes there later, so I'll look how to fix that :)

@mattgodbolt mattgodbolt merged commit f000d51 into compiler-explorer:main Jul 12, 2021
@dkm dkm deleted the pr/rustc_cg_gcc branch July 12, 2021 21:01
@mattgodbolt
Copy link
Member

This change is now live :)

@ojeda
Copy link
Contributor

ojeda commented Jul 13, 2021

Thanks a lot!

mattgodbolt pushed a commit that referenced this pull request Aug 2, 2021
GCC backend for rustc is still in a very early state.
It is in the process of being merged in main rustc source:
rust-lang/compiler-team#442

Currently reusing main rust compiler class and simply remove -Cllvm= argument if
any (only for intel asm syntax).

Disabling binary until the result is more friendly (currently binary are too
big).

refs #2683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST] rustc_codegen_gcc as alternative Rust compiler
4 participants