Update softprops/action-gh-release v1 -> v2 - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds an actionlint CI workflow and repo-level actionlint configuration as part of the org-wide rollout, and updates the release workflow to use softprops/action-gh-release@v2.
Changes:
- Added a new workflow to lint GitHub Actions workflow files with
rhysd/actionlint. - Added
.github/actionlint.yamlto define self-hosted runner labels and tune shellcheck gating (ignore info/style). - Bumped
softprops/action-gh-releasefromv1tov2in the release workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/lint-actions.yml | New CI workflow to run actionlint on workflow/config changes. |
| .github/workflows/build.yml | Updates release asset upload step to softprops/action-gh-release@v2. |
| .github/actionlint.yaml | Adds actionlint configuration (runner labels + shellcheck ignore patterns). |
Comments suppressed due to low confidence (1)
.github/workflows/build.yml:78
- The release job relies on GITHUB_TOKEN to upload release assets. If the repo/org default workflow token permissions are set to read-only, this step will fail; it’s safer to declare explicit
contents: writepermissions for the job.
- name: Upload Release Assets
uses: softprops/action-gh-release@v2
with:
files: |
ce-node-exporter-linux-amd64.zip
ce-node-exporter-linux-arm64.zip
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+10
to
+14
| jobs: | ||
| actionlint: | ||
| if: github.repository_owner == 'compiler-explorer' | ||
| runs-on: ubuntu-latest | ||
| steps: |
- softprops/action-gh-release v1 -> v2 (v1 runs on a deprecated node runtime) Found by an org-wide actionlint sweep; the lint tooling itself is staying in the core repos only, but these fixes stand on their own. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mattgodbolt
changed the title
mattgodbolt
force-pushed
the
add-actionlint
branch
from
July 10, 2026 21:52
103a681 to
fec621f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by an org-wide actionlint sweep. Per review feedback the lint tooling itself is staying in the core repos (compiler-explorer, infra, compiler-workflows) — this PR keeps just the fixes, which stand on their own:
🤖 Generated with Claude Code