-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heroku docker deploy #962
Heroku docker deploy #962
Conversation
This reverts commit 8ee3cfa.
The report repo isn't building any more here for some reason:
See at the end here: https://github.com/compdemocracy/polis/pull/962/checks?check_run_id=2357063989 |
@micahstubbs Any chance you could help out with the npm ci issue (and review if you have time)? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. This all looks really good. If it builds and deploys properly I guess that is the real test.
I'm curious about the four canonical branches: Is main more stable than stable?
Odd. Doesn't seem to be any visible issue at line 350 of lockfile...? |
Looks neat! Stoked for this to land. Small note of caution on using clojure for build system and general scripting stuff. JS sometimes sucks, but clojure (may it achieve great success! ✊) might confound many future contributors from engaging if they're in a learned helplessness mode in such a core system. Also, if it has issues, ppl might immediate be discouraged, whereas issues in JS might mean they'll dive in to resolve. Only a fractional number of people will be able to offer support if something needs improvement (the hardcore ppl will learn, but many will just be like "i don't understand what seems to be the entry point of polis") JS vs shell vs clojure pushes (this quarter)https://madnight.github.io/githut/#/pull_requests/2021/1 But anyhow, +1 of merging, regardless, just something to be mindful of in long run 🙃 |
Thanks for the review @ballPointPenguin!
We're transitioning from |
…-deploy Heroku docker deploy
…-deploy Heroku docker deploy
…-deploy Heroku docker deploy
This PR contains some work that we've done in order to get polis deployed through heroku, as well as some generic improvements to the deployment & dev setup infrastructure.