Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku docker deploy #962

Merged
merged 36 commits into from
Apr 19, 2021
Merged

Heroku docker deploy #962

merged 36 commits into from
Apr 19, 2021

Conversation

metasoarous
Copy link
Member

This PR contains some work that we've done in order to get polis deployed through heroku, as well as some generic improvements to the deployment & dev setup infrastructure.

@metasoarous
Copy link
Member Author

The report repo isn't building any more here for some reason:

#9 ERROR: executor failed running [/bin/sh -c npm ci]: exit code: 1
------
 > [5/8] RUN npm ci:
------
executor failed running [/bin/sh -c npm ci]: exit code: 1
Service 'client-report' failed to build
Error: Process completed with exit code 1.

See at the end here: https://github.com/compdemocracy/polis/pull/962/checks?check_run_id=2357063989

@metasoarous
Copy link
Member Author

@micahstubbs Any chance you could help out with the npm ci issue (and review if you have time)? Thanks!

Copy link
Contributor

@ballPointPenguin ballPointPenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. This all looks really good. If it builds and deploys properly I guess that is the real test.
I'm curious about the four canonical branches: Is main more stable than stable?

@patcon
Copy link
Contributor

patcon commented Apr 16, 2021

Odd. Doesn't seem to be any visible issue at line 350 of lockfile...?
https://github.com/compdemocracy/polis/blob/heroku-docker-deploy/client-report/package-lock.json#L350

@patcon
Copy link
Contributor

patcon commented Apr 19, 2021

Looks neat! Stoked for this to land.

Small note of caution on using clojure for build system and general scripting stuff. JS sometimes sucks, but clojure (may it achieve great success! ✊) might confound many future contributors from engaging if they're in a learned helplessness mode in such a core system. Also, if it has issues, ppl might immediate be discouraged, whereas issues in JS might mean they'll dive in to resolve.

Only a fractional number of people will be able to offer support if something needs improvement (the hardcore ppl will learn, but many will just be like "i don't understand what seems to be the entry point of polis")

JS vs shell vs clojure pushes (this quarter)

Screen Shot 2021-04-19 at 3 20 24 PM

https://madnight.github.io/githut/#/pull_requests/2021/1

But anyhow, +1 of merging, regardless, just something to be mindful of in long run 🙃

@metasoarous metasoarous merged commit 38d4950 into dev Apr 19, 2021
@metasoarous
Copy link
Member Author

Thanks for the review @ballPointPenguin!

I'm curious about the four canonical branches: Is main more stable than stable?

We're transitioning from dev -> edge and main -> stable. For right now I'm just adding actions for all of them so that there isn't as much fussing to do when we're ready to make the transition.

@colinmegill colinmegill deleted the heroku-docker-deploy branch April 20, 2021 02:41
raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Sep 1, 2021
raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Oct 26, 2021
raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants