WIP: Feature/crkrenn/e2e cypress 12 #1572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Big yes!
|
|
Yes! This would be fantastic. |
|
I'll takes these responses as encouragement to proceed. I will do so! |
|
Hey @crkrenn. This is still in draft, but as far as you're concerned is this ready to merge? I don't think we need all of the tests passing yet, since this still seems like an overall improvement. Thanks! |
|
I'm almost certain that edge is already running cypress 12, but I didn't link the pull request with the issue. I'll try to do that in the future. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@metasoarous
Would you both be supportive of a pull request that migrated the existing cypress tests from cypress version 6.8.0 to version 12.0.1?
There have been significant improvements since version 6.8, and I think the migrated version will be easier to maintain, extend, and further robustify. This should go a long way towards resolving #1392.
I've started the process on this pull request.
Please let me know what you think.
Thanks!
-Chris