Fix e2e tests (re: maildev container) #1521
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for maildev container)
|
Ah! Third party services :) a difficult and flaky bit to test... thanks for this PR, it would be great to have the cypress tests passing |
|
Heh yep, super-helpful until it takes down the testing infra :) but yay, so now the email test that's been red for a stretch is green! though the actually flaky kitchensink one is now red 😞 But I suspect re-running the e2e tests as-is will bring it green 🤞 |
|
This is complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential resolution for #1392 (comment)
I think the issue was that that docker-compose was split into prod file and dev files awhile back, but e2e CI workflow hasn't yet been updated to merge in the dev file when running -- the dev file helps stand up a fake mailserver that's used to exercise email features.
As context,
docker-compose.override.ymlis a special filename that is auto-read by docker without an explicit-f docker-compose.override.ymlflag: https://docs.docker.com/compose/extends/#understanding-multiple-compose-filesThis makes it easier to run development commands. Should I also swap out the
docker-compose -f docker-compose.yml -f docker-compose.dev.yml [...]instructions in the readme for this approach?