[extended] convert server/ to TypeScript #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patcon
requested review from
a team and
micahstubbs
and removed request for
ballPointPenguin and
metasoarous
micahstubbs
approved these changes
Dec 12, 2021
|
@colinmegill Was just reviewing this! You beat me to it :-) |
metasoarous
reviewed
Dec 13, 2021
| @@ -30,6 +30,7 @@ services: | |||
| - "polis-net" | |||
| ports: | |||
| - "5000:5000" | |||
| - "9229:9229" | |||
There was a problem hiding this comment.
@colinmegill @patcon @micahstubbs As mentioned here, this should be unnecessary given the docker-compose.dev.yml, and needs to be removed as part of the process of moving all of the development related docker-compose.yml config over to *.dev.yml (in order to get our docker compose setup production ready).
|
Thanks so much @micahstubbs and @patcon for getting this in! |
|
I am so stoked for this guys! Thanks a million, @micahstubbs! 🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #961
Same PR, but with my extra fix-up commits pulled in (see #961 (comment)), which should pass the tests for simplest possible merge.