Run devenv.exe /upgrade before build #26
Conversation
This run devenv /upgrade in order to make sass-rs to build on appveyor's VS2017 image No panic if upgrade fails Exec upgrade only if devenv is present compile fix test VS2015 add i686 test VS2017 Restore appveyor
|
Does this fix the issue Cobalt has? Can we also update this repo appveyor to use 2017? |
|
As for cobalt, I don't know yet, but this repo build with VS2013, VS2015 and VS2017 images on appveyor :) |
|
Can you update https://github.com/compass-rs/sass-rs/blob/master/appveyor.yml#L1 to use 2017 then as well as base image please? Let's wait to see if that fixes the issue with Cobalt before merging. |
|
How can I test for cobalt? I think it will work as I've tested it on my computer by modifying build.rs locally in the cargo register and it works :) |
|
Enable appveyor on your cobalt fork and use a git path for the sass-rs dependency https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#specifying-dependencies-from-git-repositories |
|
Thanks, how do I specify git path when the dependency has this format: |
|
Go it: |
|
Nice! How does sass/libsass#2648 fit into that PR? |
|
It will upgrade their project to VS2017 and no impact for this PR as if already upgraded, nothing will happen :) |
sass-sys/build.rs
Outdated
| @@ -75,6 +75,20 @@ fn compile() { | |||
| } else { | |||
| "Win32" | |||
| }; | |||
|
|
|||
| let d = gcc::windows_registry::find(target.as_str(), "devenv.exe"); | |||
There was a problem hiding this comment.
can you add a comment explaining what this does? I'll merge it after
|
Done!
It seems that they won't accept the PR so we need this one to allows us to build with VS2017. They say it shouldn't ask for VS2010 so maybe something wrong with how |
|
Oh no… I though this |
|
I just realised a mistake for i686, fixing it right now |
|
I just started getting the same kind of error on appveyor as well in https://ci.appveyor.com/project/Keats/gutenberg so hopefully this will fix my issues as well |
|
Fingers crossed, but I think we'll still have some of these event if it's better with VS2017, I got one locally yesterday for the first time since investigating this issue |
|
It doesn't fix the error in Gutenberg sadly :/ https://ci.appveyor.com/project/Keats/gutenberg |
|
This happened before on rust's github: rust-lang/rust#33145 It's considered fixed but obviously, something similar is happening :-/ |
|
I'm going to try with different versions of Rust on appveyor as I didn't run into that at all before |
|
Keep us posted, we're interested as well :D |
|
found this: rust-lang/cargo#3161 (comment) I'll give it a shot tonight |
This run devenv /upgrade in order to make sass-rs to build on appveyor's VS2017 image