fix(pbr): fix mlp flicker and wrong coat color, convert additional color maps like albedo#967
Merged
Merged
Conversation
Collaborator
|
we shouldn't flatten actually |
Contributor
Author
|
Copied the code with flatten from elsewhere, ig in another PR remove all flatten from related code. I'll add more fixes to this pr cos I didn't switch branches 😐 |
ThePagi
changed the title
Contributor
Author
|
Changes: |
Collaborator
|
ready for merge? |
doodlum
approved these changes
Feb 16, 2025
alandtse
pushed a commit
to alandtse/open-shaders
that referenced
this pull request
Jul 20, 2025
…lor maps like albedo (community-shaders#967) * fix(pbr): fix mlp flicker * style: 🎨 apply clang-format changes * Update Lighting.hlsl * style: 🎨 apply clang-format changes --------- Co-authored-by: ThePagi <ThePagi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check to avoid wrongly converting MLP view dir on armor (smh)