Skip to content

docs: improve compilation instructions#85

Merged
doodlum merged 6 commits into
community-shaders:mainfrom
AceAmir:main
Sep 10, 2023
Merged

docs: improve compilation instructions#85
doodlum merged 6 commits into
community-shaders:mainfrom
AceAmir:main

Conversation

@AceAmir

@AceAmir AceAmir commented Sep 10, 2023

Copy link
Copy Markdown
Contributor

Rework of Readme's instructions to help clarify installation and configuration of requirements to compile Community Shaders.

Rework of Readme's instructions to help clarify installation and configuration of requirements to compile Community Shaders.
@doodlum

doodlum commented Sep 10, 2023

Copy link
Copy Markdown
Collaborator

"environment" is spelt wrong, please correct any grammatical mistakes

@AceAmir

AceAmir commented Sep 10, 2023

Copy link
Copy Markdown
Contributor Author

That's what I get for writing this in Notepad without my spellchecker...

Spelling mistake corrected, and added suggested re-wording to communicate that any preferred terminal is usable.

Removed explicit install instructions for Vcpkg in the event changes are made upstream to its installation process.
@alandtse alandtse changed the title Update README.md docs: improve compilation instructions Sep 10, 2023
Comment thread README.md Outdated

@alandtse alandtse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@AceAmir

AceAmir commented Sep 10, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the catch, alan. Fixed!

@alandtse alandtse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Thanks.

@doodlum doodlum merged commit 5622ccf into community-shaders:main Sep 10, 2023
doodlum added a commit that referenced this pull request Sep 13, 2023
* chore: polish Feature menus (#82)

* Some polishing of the Feature menus

* style: 🎨 apply clang-format changes

---------

Co-authored-by: TheRiverwoodModder <TheRiverwoodModder@users.noreply.github.com>

* docs: improve compilation instructions (#85)

* Update README.md

Rework of Readme's instructions to help clarify installation and configuration of requirements to compile Community Shaders.

* Update README.md

* Update README.md

* Update README.md

* Update README.md

Removed explicit install instructions for Vcpkg in the event changes are made upstream to its installation process.

* Update README.md

* feat: add NPC grass collision (#79)

* fix: fix bug where collisionCount always 0

It now will remember the last value from the prior frame.

* feat: add npc grass collision

Allows NPCs to cause grass collisions. This is more costly than the
player only version. However, additional settings have been added to
tune quality over performance. We should ask testers for good defaults.

The commit currently enables NPC collisions by default. We can disable
with maxDistance set to 0.

* style: 🎨 apply clang-format changes

* Some polishing of the Feature menus

* style: 🎨 apply clang-format changes

* chore: convert to popups in menu

---------

Co-authored-by: TheRiverwoodModder <125157333+TheRiverwoodModder@users.noreply.github.com>
Co-authored-by: TheRiverwoodModder <TheRiverwoodModder@users.noreply.github.com>

* feat: improve ShaderCache (#86)

* feat: improve ShaderCache

* Add error message when compiler failure detected. Error may be hidden
but menu will be in red font to indicate failure state.
* Add statistics to compilation message and advanced options, including
estimated completion time and data on failures and cache hits.
* Add setting to change the Compiler Thread count. This may allow users
to avoid crashes and unresponsiveness.
* Fix logic to detect failed shaders appropriately and avoid infinite
compilation bug.
* Fix bug where Shader Defines would not load if loglevel was malformed.

closes #71

* fix: fix hashkey to avoid hashing on descriptor

Remove descriptor from string generated for hashkeys. On 1.5.97, I see
3.8K worth of hits which may be the permutations discussed here (# 72).

* fix: set bLandSpecular to support Terrain Parallax (#88)

* refactor: remove redundant state load

* fix: set bLandSpecular to support Terrain Parallax

bLandSpecular may be disabled by certain mod lists and is necessary for
terrain parallax. This will force the setting to true when Terrain
Parallax is enabled.

* docs: simplify build commands

* build: fix subsurface directory structure

Auto deploy scripts were broken due to missing Shaders subdirectory in
/Features

* build: list features for auto deployment

* feat: enable VR building for SSS

* style: clang format

---------

Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>
Co-authored-by: TheRiverwoodModder <125157333+TheRiverwoodModder@users.noreply.github.com>
Co-authored-by: TheRiverwoodModder <TheRiverwoodModder@users.noreply.github.com>
Co-authored-by: AceAmir <73254124+AceAmir@users.noreply.github.com>
Co-authored-by: Pentalimbed <76898260+Pentalimbed@users.noreply.github.com>
alandtse referenced this pull request in alandtse/open-shaders Sep 15, 2023
* chore: polish Feature menus (#82)

* Some polishing of the Feature menus

* style: 🎨 apply clang-format changes

---------

Co-authored-by: TheRiverwoodModder <TheRiverwoodModder@users.noreply.github.com>

* docs: improve compilation instructions (#85)

* Update README.md

Rework of Readme's instructions to help clarify installation and configuration of requirements to compile Community Shaders.

* Update README.md

* Update README.md

* Update README.md

* Update README.md

Removed explicit install instructions for Vcpkg in the event changes are made upstream to its installation process.

* Update README.md

* feat: add NPC grass collision (#79)

* fix: fix bug where collisionCount always 0

It now will remember the last value from the prior frame.

* feat: add npc grass collision

Allows NPCs to cause grass collisions. This is more costly than the
player only version. However, additional settings have been added to
tune quality over performance. We should ask testers for good defaults.

The commit currently enables NPC collisions by default. We can disable
with maxDistance set to 0.

* style: 🎨 apply clang-format changes

* Some polishing of the Feature menus

* style: 🎨 apply clang-format changes

* chore: convert to popups in menu

---------

Co-authored-by: TheRiverwoodModder <125157333+TheRiverwoodModder@users.noreply.github.com>
Co-authored-by: TheRiverwoodModder <TheRiverwoodModder@users.noreply.github.com>

* feat: improve ShaderCache (#86)

* feat: improve ShaderCache

* Add error message when compiler failure detected. Error may be hidden
but menu will be in red font to indicate failure state.
* Add statistics to compilation message and advanced options, including
estimated completion time and data on failures and cache hits.
* Add setting to change the Compiler Thread count. This may allow users
to avoid crashes and unresponsiveness.
* Fix logic to detect failed shaders appropriately and avoid infinite
compilation bug.
* Fix bug where Shader Defines would not load if loglevel was malformed.

closes #71

* fix: fix hashkey to avoid hashing on descriptor

Remove descriptor from string generated for hashkeys. On 1.5.97, I see
3.8K worth of hits which may be the permutations discussed here (# 72).

* fix: set bLandSpecular to support Terrain Parallax (#88)

* refactor: remove redundant state load

* fix: set bLandSpecular to support Terrain Parallax

bLandSpecular may be disabled by certain mod lists and is necessary for
terrain parallax. This will force the setting to true when Terrain
Parallax is enabled.

* docs: simplify build commands

* build: fix subsurface directory structure

Auto deploy scripts were broken due to missing Shaders subdirectory in
/Features

* build: list features for auto deployment

* feat: enable VR building for SSS

* style: clang format

---------

Co-authored-by: doodlum <15017472+doodlum@users.noreply.github.com>
Co-authored-by: TheRiverwoodModder <125157333+TheRiverwoodModder@users.noreply.github.com>
Co-authored-by: TheRiverwoodModder <TheRiverwoodModder@users.noreply.github.com>
Co-authored-by: AceAmir <73254124+AceAmir@users.noreply.github.com>
Co-authored-by: Pentalimbed <76898260+Pentalimbed@users.noreply.github.com>
alandtse referenced this pull request in alandtse/open-shaders Jul 20, 2025
* Update README.md

Rework of Readme's instructions to help clarify installation and configuration of requirements to compile Community Shaders.

* Update README.md

* Update README.md

* Update README.md

* Update README.md

Removed explicit install instructions for Vcpkg in the event changes are made upstream to its installation process.

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants