Skip to content

fix(water-caustics): X4000 warnings #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkrubbySkrubInAShrub merged 1 commit into from
Jun 8, 2026
Merged

fix(water-caustics): X4000 warnings #2488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions features/Water Effects/Shaders/WaterEffects/WaterCaustics.hlsli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,19 +38,21 @@ namespace WaterEffects
float2 causticsUV1 = PanCausticsUV(causticsUV, 0.5 * 0.2, 1.0);
float2 causticsUV2 = PanCausticsUV(causticsUV, 1.0 * 0.2, -0.5);

const float3 causticsHigh =
(causticsFade > 0.0) ? (min(SampleCausticsDispersion(causticsUV1, dispersionOffset), SampleCausticsDispersion(causticsUV2, dispersionOffset)) * 4.0) : 1.0.xxx;
float3 causticsHigh = 1.0.xxx;
if (causticsFade > 0.0)
causticsHigh = min(SampleCausticsDispersion(causticsUV1, dispersionOffset), SampleCausticsDispersion(causticsUV2, dispersionOffset)) * 4.0;

causticsUV *= 0.5;
dispersionOffset *= 0.5;

causticsUV1 = PanCausticsUV(causticsUV, 0.5 * 0.1, 1.0);
causticsUV2 = PanCausticsUV(causticsUV, 1.0 * 0.1, -0.5);

const float3 causticsLow =
(causticsFade < 1.0) ? (min(SampleCausticsDispersion(causticsUV1, dispersionOffset), SampleCausticsDispersion(causticsUV2, dispersionOffset)) * 4.0) : 1.0.xxx;
float3 causticsLow = 1.0.xxx;
if (causticsFade < 1.0)
causticsLow = min(SampleCausticsDispersion(causticsUV1, dispersionOffset), SampleCausticsDispersion(causticsUV2, dispersionOffset)) * 4.0;

const float3 caustics = lerp(causticsLow, causticsHigh, causticsFade);
float3 caustics = lerp(causticsLow, causticsHigh, causticsFade);
return lerp(1.0.xxx, caustics, shoreFactorCaustics);
}

Expand Down
Loading