Skip to content

chore(cs-editor): reduce logging#2471

Merged
SkrubbySkrubInAShrub merged 1 commit into
community-shaders:devfrom
SkrubbySkrubInAShrub:CS-editor-logging
Jun 4, 2026
Merged

chore(cs-editor): reduce logging#2471
SkrubbySkrubInAShrub merged 1 commit into
community-shaders:devfrom
SkrubbySkrubInAShrub:CS-editor-logging

Conversation

@SkrubbySkrubInAShrub

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

give info instead when files are detected.

Summary by CodeRabbit

  • Bug Fixes
    • Improved widget settings directory handling to suppress false warnings when the directory is not found, while maintaining error reporting for other filesystem issues.
    • Enhanced logging to better track when widget settings are detected during system operations.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b6bc28b7-35ab-4709-967b-48c5e008eddf

📥 Commits

Reviewing files that changed from the base of the PR and between 38d3ce8 and 96ad056.

📒 Files selected for processing (1)
  • src/Features/CSEditor.cpp

📝 Walkthrough

Walkthrough

CSEditor's HasWidgetJsonFiles() function now suppresses warnings for missing widget settings directories (treating the missing-directory error as normal) while preserving warnings for other filesystem errors. Additionally, the function now logs an informational message when widget settings JSON files are detected during directory scanning.

Changes

Widget JSON Detection Logging

Layer / File(s) Summary
Widget JSON detection logging improvements
src/Features/CSEditor.cpp
Error handling adjusted to suppress warnings for missing directories; informational logging added when widget JSON files are detected.

🎯 2 (Simple) | ⏱️ ~5 minutes

🐰 A hop through the code, a tweak so slight,
Warnings now whisper when folders take flight,
JSON files found? Log with delight!
Error codes tamed, the path shines bright! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(cs-editor): reduce logging' accurately summarizes the main change: the PR reduces logging verbosity by converting warning-level logs to informational-level logs.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.22.0)

OpenGrep fatal error (exit code 2): [00.12][ERROR]: Error: exception Unix_error: No such file or directory stat src/Features/CSEditor.cpp
Raised by primitive operation at UTmp.replace_named_pipe_by_regular_file_if_needed in file "libs/commons/UTmp.ml", line 145, characters 8-27
Called from Scan_CLI.replace_target_roots_by_regular_files_where_needed.(fun) in file "src/osemgrep/cli_scan/Scan_CLI.ml", lines 1086-1087, characters 19-65
Called from List_.fast_map in file "libs/commons/List_.ml", line 81, characters 17-20
Called from Sc

🔧 Infer (1.2.0)
src/Features/CSEditor.cpp

Usage Error: Failed to execute compilation command:
'/opt/infer-linux-x86_64-v1.2.0/lib/infer/infer/bin/../../facebook-clang-plugins/clang/install/bin/clang++'
-c src/Features/CSEditor.cpp -o
/tmp/coderabbit-infer/e9e98acad20a3c93/file.o

Error message:
clang++: error: no such file or directory: 'src/Features/CSEditor.cpp'

*** Infer needs a working compilation command to run.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

No actionable suggestions for changed features.

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown

✅ A pre-release build is available for this PR:
Download

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub merged commit e7194b8 into community-shaders:dev Jun 4, 2026
13 checks passed
@SkrubbySkrubInAShrub SkrubbySkrubInAShrub deleted the CS-editor-logging branch June 4, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants