Skip to content

ci: let feature version audit skip checking feature cpp#2424

Merged
SkrubbySkrubInAShrub merged 1 commit into
devfrom
ci-featureversionaudit-skipcpp
May 27, 2026
Merged

ci: let feature version audit skip checking feature cpp#2424
SkrubbySkrubInAShrub merged 1 commit into
devfrom
ci-featureversionaudit-skipcpp

Conversation

@jiayev
Copy link
Copy Markdown
Collaborator

@jiayev jiayev commented May 26, 2026

Summary by CodeRabbit

  • Chores

    • Streamlined feature version audit tooling.
  • Refactor

    • Updated feature change detection to focus on packaged features directory, reducing scanned file scope.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f79f4bae-950b-45ff-a017-c757fca1da29

📥 Commits

Reviewing files that changed from the base of the PR and between d7e2fa4 and 141aafe.

📒 Files selected for processing (1)
  • tools/feature_version_audit.py

📝 Walkthrough

Walkthrough

This PR narrows the feature version audit tool's change detection scope to packaged features/ directory content only. The tool previously tracked changes in both the packaged directory and corresponding src/Features header/source files; those dual-path detection paths are now removed.

Changes

Feature version audit scope narrowing

Layer / File(s) Summary
Changelog path simplification
tools/feature_version_audit.py
get_feature_changelog stops augmenting git-log paths with header/source locations under src/Features derived from feature_info; git-log queries now use only the packaged feature paths.
Feature analysis scope narrowing
tools/feature_version_audit.py
In analyze_features, the only_changed branch narrows git diff --name-status scanning to features/ only (removing src/Features targets), removes the inference logic that derived feature names from src/Features/[Feature Name] paths, and simplifies both PR-scoped and release-scoped change sets to use only get_changed_files(feature_dir, <ref>) (removing expansion to C/C++ header files and the special VR VRStereoOptimizations case).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • alandtse
  • doodlum

Poem

🐰 Audit scope refined with care,
Dual paths trimmed, now features bare,
Just packaged files in sight,
The tool's now lean and tight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: narrowing feature version audit scope to exclude C/C++ files from src/Features directories.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-featureversionaudit-skipcpp

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 OpenGrep (1.22.0)

OpenGrep fatal error (exit code 2): [00.15][ERROR]: Error: exception Unix_error: No such file or directory stat tools/feature_version_audit.py
Raised by primitive operation at UTmp.replace_named_pipe_by_regular_file_if_needed in file "libs/commons/UTmp.ml", line 145, characters 8-27
Called from Scan_CLI.replace_target_roots_by_regular_files_where_needed.(fun) in file "src/osemgrep/cli_scan/Scan_CLI.ml", lines 1086-1087, characters 19-65
Called from List_.fast_map in file "libs/commons/List_.ml", line 81, characters 17-20
Called fr


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SkrubbySkrubInAShrub SkrubbySkrubInAShrub merged commit 54ea123 into dev May 27, 2026
7 checks passed
@SkrubbySkrubInAShrub SkrubbySkrubInAShrub deleted the ci-featureversionaudit-skipcpp branch May 27, 2026 09:24
IgorAlanAlbuquerque pushed a commit to IgorAlanAlbuquerque/skyrim-community-shaders that referenced this pull request May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants